linux-kernel - Re: [PATCH v4] selftests: add tests for clone3()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 12 Nov 2019 12:10:33 +0100
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Adrian Reber <areber@...hat.com>
Cc:     Shuah Khan <shuah@...nel.org>,
        Eugene Syromiatnikov <esyr@...hat.com>,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] selftests: add tests for clone3()

On Tue, Nov 12, 2019 at 11:45:05AM +0100, Christian Brauner wrote:
> On Tue, Nov 12, 2019 at 11:28:14AM +0100, Christian Brauner wrote:
> > On Tue, Nov 12, 2019 at 10:58:51AM +0100, Adrian Reber wrote:
> > > This adds tests for clone3() with different values and sizes
> > > of struct clone_args.
> > > 
> > > This selftest was initially part of of the clone3() with PID selftest.
> > > After that patch was almost merged Eugene sent out a couple of patches
> > > to fix problems with these test.
> > > 
> > > This commit now only contains the clone3() selftest after the LPC
> > > decision to rework clone3() with PID to allow setting the PID in
> > > multiple PID namespaces including all of Eugene's patches.
> > > 
> > > Signed-off-by: Eugene Syromiatnikov <esyr@...hat.com>
> > > Signed-off-by: Adrian Reber <areber@...hat.com>
> > 
> > Queuing up for 5.5.
> > Thanks, Adrian!
> > 
> > Reviewed-by: Christian Brauner <christian.brauner@...ntu.com>
> 
> One thing, can you tell me what the base tree for your commit is,
> please? Given that this is just one commit it should be enough if you
> give me the "base-commit" line from the end of the patch created via:
> git format-patch --base=HEAD~1 HEAD~1

Ok, merge base commit seems to have been v5.4-rc7. I've resolved a minor
merge conflict (cf. [2]) when applying this commit to [1].

Christian

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git/log/?h=pidfd
[2]:

diff --cc tools/testing/selftests/clone3/.gitignore
index 6c9f98097774,85d9d3ba2524..000000000000
--- a/tools/testing/selftests/clone3/.gitignore
+++ b/tools/testing/selftests/clone3/.gitignore
@@@ -1,1 -1,1 +1,2 @@@
+ clone3
 +clone3_clear_sighand
diff --cc tools/testing/selftests/clone3/Makefile
index e6f259321e16,ea922c014ae4..000000000000
--- a/tools/testing/selftests/clone3/Makefile
+++ b/tools/testing/selftests/clone3/Makefile
@@@ -1,6 -1,7 +1,6 @@@
- # SPDX-License-Identifier: GPL-2.0-only
+ # SPDX-License-Identifier: GPL-2.0
 +CFLAGS += -g -I../../../../usr/include/

- TEST_GEN_PROGS := clone3_clear_sighand
 -CFLAGS += -I../../../../usr/include/
 -
 -TEST_GEN_PROGS := clone3
++TEST_GEN_PROGS := clone3 clone3_clear_sighand

  include ../lib.mk