[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20191112005802.GA9638@bogus>
Date: Mon, 11 Nov 2019 18:58:02 -0600
From: Rob Herring <robh@...nel.org>
To: Jeffrey Hugo <jhugo@...eaurora.org>
Cc: mturquette@...libre.com, sboyd@...nel.org, mark.rutland@....com,
agross@...nel.org, bjorn.andersson@...aro.org,
marc.w.gonzalez@...e.fr, linux-arm-msm@...r.kernel.org,
linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org
Subject: Re: [PATCH v8 2/4] dt-bindings: clock: Convert qcom,mmcc to DT schema
On Fri, Nov 08, 2019 at 04:17:33PM -0700, Jeffrey Hugo wrote:
> Convert the qcom,mmcc-X clock controller binding to DT schema.
>
> Signed-off-by: Jeffrey Hugo <jhugo@...eaurora.org>
> ---
> .../devicetree/bindings/clock/qcom,mmcc.txt | 28 ----------
> .../devicetree/bindings/clock/qcom,mmcc.yaml | 59 ++++++++++++++++++++++
> 2 files changed, 59 insertions(+), 28 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/clock/qcom,mmcc.txt
> create mode 100644 Documentation/devicetree/bindings/clock/qcom,mmcc.yaml
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,mmcc.txt b/Documentation/devicetree/bindings/clock/qcom,mmcc.txt
> deleted file mode 100644
> index 8b0f784..0000000
> --- a/Documentation/devicetree/bindings/clock/qcom,mmcc.txt
> +++ /dev/null
> @@ -1,28 +0,0 @@
> -Qualcomm Multimedia Clock & Reset Controller Binding
> -----------------------------------------------------
> -
> -Required properties :
> -- compatible : shall contain only one of the following:
> -
> - "qcom,mmcc-apq8064"
> - "qcom,mmcc-apq8084"
> - "qcom,mmcc-msm8660"
> - "qcom,mmcc-msm8960"
> - "qcom,mmcc-msm8974"
> - "qcom,mmcc-msm8996"
> -
> -- reg : shall contain base register location and length
> -- #clock-cells : shall contain 1
> -- #reset-cells : shall contain 1
> -
> -Optional properties :
> -- #power-domain-cells : shall contain 1
> -
> -Example:
> - clock-controller@...0000 {
> - compatible = "qcom,mmcc-msm8960";
> - reg = <0x4000000 0x1000>;
> - #clock-cells = <1>;
> - #reset-cells = <1>;
> - #power-domain-cells = <1>;
> - };
> diff --git a/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml
> new file mode 100644
> index 0000000..61ed4a2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/bindings/clock/qcom,mmcc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Multimedia Clock & Reset Controller Binding
> +
> +maintainers:
> + - Jeffrey Hugo <jhugo@...eaurora.org>
> +
> +description: |
> + Qualcomm multimedia clock control module which supports the clocks, resets and
> + power domains.
> +
> +properties:
> + compatible :
> + enum:
> + - qcom,mmcc-apq8064
> + - qcom,mmcc-apq8084
> + - qcom,mmcc-msm8660
> + - qcom,mmcc-msm8960
> + - qcom,mmcc-msm8974
> + - qcom,mmcc-msm8996
> +
> + '#clock-cells':
> + const: 1
> +
> + '#reset-cells':
> + const: 1
> +
> + '#power-domain-cells':
> + const: 1
> +
> + reg:
> + maxItems: 1
> +
> + protected-clocks:
> + description:
> + Protected clock specifier list as per common clock binding
Wasn't documented before. Okay to add here, but mention it in the commit
msg.
> +
> +required:
> + - compatible
> + - reg
> + - '#clock-cells'
> + - '#reset-cells'
> + - '#power-domain-cells'
> +
> +examples:
> + # Example for MMCC for MSM8960:
> + - |
> + clock-controller@...0000 {
> + compatible = "qcom,mmcc-msm8960";
> + reg = <0x4000000 0x1000>;
> + #clock-cells = <1>;
> + #reset-cells = <1>;
> + #power-domain-cells = <1>;
> + };
> +...
> --
> Qualcomm Technologies, Inc. is a member of the
> Code Aurora Forum, a Linux Foundation Collaborative Project.
>
Powered by blists - more mailing lists