linux-kernel - Re: [PATCH][next] net: dsa: mv88e6xxx: fix broken if statement because of a stray semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Nov 2019 14:27:28 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Colin King <colin.king@...onical.com>
Cc:     Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Iwan R Timmer <irtimmer@...il.com>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] net: dsa: mv88e6xxx: fix broken if statement
 because of a stray semicolon

On Tue, Nov 12, 2019 at 01:05:23PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> There is a stray semicolon in an if statement that will cause a dev_err
> message to be printed unconditionally. Fix this by removing the stray
> semicolon.
> 
> Addresses-Coverity: ("Stay semicolon")
> Fixes: f0942e00a1ab ("net: dsa: mv88e6xxx: Add support for port mirroring")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew