linux-kernel - Re: [PATCH 2/2] sched/deadline: Temporary copy static parameters to boosted non-DEADLINE entities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191112135623.GU5671@hirez.programming.kicks-ass.net>
Date:   Tue, 12 Nov 2019 14:56:23 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Juri Lelli <juri.lelli@...hat.com>
Cc:     mingo@...hat.com, glenn@...ora.tech, linux-kernel@...r.kernel.org,
        rostedt@...dmis.org, vincent.guittot@...aro.org,
        dietmar.eggemann@....com, tglx@...utronix.de,
        luca.abeni@...tannapisa.it, c.scordino@...dence.eu.com,
        tommaso.cucinotta@...tannapisa.it, bristot@...hat.com
Subject: Re: [PATCH 2/2] sched/deadline: Temporary copy static parameters to
 boosted non-DEADLINE entities

On Tue, Nov 12, 2019 at 11:51:30AM +0100, Peter Zijlstra wrote:

>  	dl_se->deadline = rq_clock(rq) + dl_se->dl_deadline;
> +	dl_se->normal_deadline = dl_se->deadline;

Or rather something like:

static inline dl_set_deadline(struct sched_dl_entity *dl_se, u64 deadline)
{
	dl_se->normal_deadline = deadline;
	/*
	 * We should never update the deadline while boosted,
	 * but if we do, make sure to not change the effective
	 * deadline until deboost.
	 */
	if (WARN_ON_ONCE(dl_se->dl_boosted))
		return;
	dl_se->deadline = dl_se->normal_deadline;
}