linux-kernel - Re: [PATCH 1/1] PCI: Fix bug resulting in double hpmemsize being assigned to MMIO window

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191112142402.GA34425@lahna.fi.intel.com>
Date:   Tue, 12 Nov 2019 16:24:02 +0200
From:   "mika.westerberg@...ux.intel.com" <mika.westerberg@...ux.intel.com>
To:     Nicholas Johnson <nicholas.johnson-opensource@...look.com.au>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "corbet@....net" <corbet@....net>,
        "benh@...nel.crashing.org" <benh@...nel.crashing.org>,
        "logang@...tatee.com" <logang@...tatee.com>
Subject: Re: [PATCH 1/1] PCI: Fix bug resulting in double hpmemsize being
 assigned to MMIO window

On Tue, Nov 12, 2019 at 02:17:35PM +0000, Nicholas Johnson wrote:
> > >  	if (!b_res)
> > >  		return;
> > 
> > I think it may be good to comment here that skip the resources that are
> > assigned (->parent != NULL).
> 
> Something like
> 
> /* If resource is already assigned, nothing more to do. */

This one looks good to me.