linux-kernel - Re: [PATCH] tty: fill console_driver->driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+1SViCyCb9OPsRpL_4CrkRjcMJeV08298XxAOeb8_hyT_11Ug@mail.gmail.com>
Date:   Tue, 12 Nov 2019 09:00:04 +0800
From:   Cheng Chao <cs.os.kernel@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     jslaby@...e.com, nico@...xnic.net, textshell@...uujin.de,
        sam@...nborg.org, Daniel Vetter <daniel.vetter@...ll.ch>,
        mpatocka@...hat.com, ghalat@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: fill console_driver->driver_name

Thank greg k-h.
1. I guess nothing is going to break with this change, I'm not sure about that
2. why does it need to be changed?
    "unknown" confuse us a little, and we want to know the reason: bug
or some else.
    In fact, it is a known tty driver.
3. finally, I also consider this patch is trivial, but I just expect
"cat /proc/tty/drivers" to be better.

thanks,
Cheng

On Mon, Nov 11, 2019 at 10:27 PM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Thu, Nov 07, 2019 at 09:25:48AM +0800, Cheng Chao wrote:
> > cat /proc/tty/drivers
> > ...
> > unknown              /dev/tty        4 1-63 console
> >
> > ----------------------------------
> > after this patch:
> >
> > cat /proc/tty/drivers
> > ...
> > console              /dev/tty        4 1-63 console
>
> What is going to break with this change?  It's a user visable thing, why
> does it need to be changed?
>
> thanks,
>
> greg k-h