linux-kernel - Re: [PATCH net-next] ptp: ptp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191112144724.GA15686@renesas.com>
Date:   Tue, 12 Nov 2019 14:47:58 +0000
From:   Vincent Cheng <vincent.cheng.xh@...esas.com>
To:     YueHaibing <yuehaibing@...wei.com>
CC:     "richardcochran@...il.com" <richardcochran@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] ptp: ptp_clockmatrix: Fix build error

On Tue, Nov 12, 2019 at 09:35:14AM EST, YueHaibing wrote:
>When do randbuilding, we got this warning:
>
>WARNING: unmet direct dependencies detected for PTP_1588_CLOCK
>  Depends on [n]: NET [=y] && POSIX_TIMERS [=n]
>  Selected by [y]:
>  - PTP_1588_CLOCK_IDTCM [=y]
>
>Make PTP_1588_CLOCK_IDTCM depends on PTP_1588_CLOCK to fix this.
>
>Fixes: 3a6ba7dc7799 ("ptp: Add a ptp clock driver for IDT ClockMatrix.")
>Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>---
> drivers/ptp/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
>index c48ad23..b45d2b8 100644
>--- a/drivers/ptp/Kconfig
>+++ b/drivers/ptp/Kconfig
>@@ -121,7 +121,7 @@ config PTP_1588_CLOCK_KVM
> 
> config PTP_1588_CLOCK_IDTCM
> 	tristate "IDT CLOCKMATRIX as PTP clock"
>-	select PTP_1588_CLOCK
>+	depends on PTP_1588_CLOCK
> 	default n
> 	help
> 	  This driver adds support for using IDT CLOCKMATRIX(TM) as a PTP
>-- 

Oops. Thank-you for the fix.

Reviewed-by: Vincent Cheng  <vincent.cheng.xh@...esas.com>