linux-kernel - Re: [PATCH -next] thermal: power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191112152801.GA247051@google.com>
Date:   Tue, 12 Nov 2019 15:28:01 +0000
From:   Quentin Perret <qperret@...gle.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     rui.zhang@...el.com, edubezval@...il.com,
        daniel.lezcano@...aro.org, amit.kucheria@...durent.com,
        viresh.kumar@...aro.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] thermal: power_allocator: Fix Kconfig warning

On Tuesday 12 Nov 2019 at 15:13:19 (+0000), Quentin Perret wrote:
> On Tuesday 12 Nov 2019 at 22:51:14 (+0800), YueHaibing wrote:
> > When do randbuiding, we got this:
> > 
> > WARNING: unmet direct dependencies detected for THERMAL_GOV_POWER_ALLOCATOR
> >   Depends on [n]: THERMAL [=y] && ENERGY_MODEL [=n]
> >   Selected by [y]:
> >   - THERMAL_DEFAULT_GOV_POWER_ALLOCATOR [=y] && <choice>
> 
> This will not cause run-time problems, but I guess the warning is
> annoying so ...
> 
> > Make THERMAL_DEFAULT_GOV_POWER_ALLOCATOR also depends on ENERGY_MODEL.
> >  
> > Fixes: a4e893e802e6 ("thermal: cpu_cooling: Migrate to using the EM framework")
> 
> Daniel: can we rely on this sha1 ? Or is this branch force-pushed ?
> 
> > Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> > ---
> >  drivers/thermal/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> > index 59b79fc..5e9e038 100644
> > --- a/drivers/thermal/Kconfig
> > +++ b/drivers/thermal/Kconfig
> > @@ -108,6 +108,7 @@ config THERMAL_DEFAULT_GOV_USER_SPACE
> >  
> >  config THERMAL_DEFAULT_GOV_POWER_ALLOCATOR
> >  	bool "power_allocator"
> > +	depends on ENERGY_MODEL
> >  	select THERMAL_GOV_POWER_ALLOCATOR

And actually, instead of doing this, we probably should change this
'select THERMAL_GOV_POWER_ALLOCATOR' by a 'depends on'.

> >  	help
> >  	  Select this if you want to control temperature based on
> > -- 
> > 2.7.4
> 
> Thanks,
> Quentin