linux-kernel - Re: [PATCH] arm64: Kconfig: add a choice for endianess

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e44db1ec-e562-18c4-ca6f-96e4279564ed@huawei.com>
Date:   Tue, 12 Nov 2019 16:24:31 +0000
From:   John Garry <john.garry@...wei.com>
To:     Anders Roxell <anders.roxell@...aro.org>, <catalin.marinas@....com>
CC:     <will@...nel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: Kconfig: add a choice for endianess

On 12/11/2019 16:01, Anders Roxell wrote:
> When building allmodconfig KCONFIG_ALLCONFIG=$(pwd)/arch/arm64/configs/defconfig
> CONFIG_CPU_BIG_ENDIAN gets enabled. Which tends not to be what most
> people wants. Another concern that thas come up is that ACPI in't built

/s/wants/want/, s/thas/has/, s/in't/isn't/

> for an allmodconfig kernel today since that also depends on !CPU_BIG_ENDIAN.
> 
> Rework so that we introduce a 'choice' and default the choice to
> CPU_LITTLE_ENDIAN. That means that when we build an allmodconfig kernel
> it will default to CPU_LITTLE_ENDIAN that most people tends to want.
> 
> Signed-off-by: Anders Roxell <anders.roxell@...aro.org>

FWIW, apart from spelling mistakes:

Reviewed-by: John Garry <john.garry@...wei.com>

> ---
>   arch/arm64/Kconfig | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 64764ca92fca..62f83c234a61 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -877,11 +877,24 @@ config ARM64_PA_BITS
>   	default 48 if ARM64_PA_BITS_48
>   	default 52 if ARM64_PA_BITS_52
>   
> +choice
> +	prompt "Endianess"

Should this be "Endianness"?

> +	default CPU_LITTLE_ENDIAN
> +	help
> +	  Choose what mode you plan on running your kernel in.
> +
>   config CPU_BIG_ENDIAN
>          bool "Build big-endian kernel"
>          help
>            Say Y if you plan on running a kernel in big-endian mode.
>   
> +config CPU_LITTLE_ENDIAN
> +	bool "Build little-endian kernel"
> +	help
> +	  Say Y if you plan on running a kernel in little-endian mode.
> +
> +endchoice
> +
>   config SCHED_MC
>   	bool "Multi-core scheduler support"
>   	help
>