linux-kernel - Re: [PATCH] PCI: pciehp: Make sure pciehp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201911132048.rcf6xpZS%lkp@intel.com>
Date:   Wed, 13 Nov 2019 20:13:04 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Stuart Hayes <stuart.w.hayes@...il.com>
Cc:     kbuild-all@...ts.01.org, Bjorn Helgaas <bhelgaas@...gle.com>,
        Austin Bolen <austin_bolen@...l.com>, keith.busch@...el.com,
        Alexandru Gagniuc <mr.nuke.me@...il.com>,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        "Gustavo A . R . Silva" <gustavo@...eddedor.com>,
        Sinan Kaya <okaya@...nel.org>,
        Oza Pawandeep <poza@...eaurora.org>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, lukas@...ner.de,
        Stuart Hayes <stuart.w.hayes@...il.com>
Subject: Re: [PATCH] PCI: pciehp: Make sure pciehp_isr clears interrupt events

Hi Stuart,

I love your patch! Perhaps something to improve:

[auto build test WARNING on pci/next]
[cannot apply to v5.4-rc7 next-20191111]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Stuart-Hayes/PCI-pciehp-Make-sure-pciehp_isr-clears-interrupt-events/20191113-174426
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/pci/hotplug/pciehp_hpc.c: In function 'pciehp_isr':
>> drivers/pci/hotplug/pciehp_hpc.c:15:22: warning: format '%s' expects argument of type 'char *', but argument 3 has type 'int' [-Wformat=]
    #define dev_fmt(fmt) "pciehp: " fmt
                         ^
   include/linux/device.h:1743:17: note: in expansion of macro 'dev_fmt'
     _dev_warn(dev, dev_fmt(fmt), ##__VA_ARGS__)
                    ^~~~~~~
>> include/linux/pci.h:2377:37: note: in expansion of macro 'dev_warn'
    #define pci_warn(pdev, fmt, arg...) dev_warn(&(pdev)->dev, fmt, ##arg)
                                        ^~~~~~~~
>> drivers/pci/hotplug/pciehp.h:42:2: note: in expansion of macro 'pci_warn'
     pci_warn(ctrl->pcie->port, format, ## arg)
     ^~~~~~~~
>> drivers/pci/hotplug/pciehp_hpc.c:568:3: note: in expansion of macro 'ctrl_warn'
      ctrl_warn(ctrl, "Slot(%s): Hot plug event bit stuck, reading %x\n",
      ^~~~~~~~~
   drivers/pci/hotplug/pciehp_hpc.c:568:26: note: format string is defined here
      ctrl_warn(ctrl, "Slot(%s): Hot plug event bit stuck, reading %x\n",
                            ~^
                            %d
>> drivers/pci/hotplug/pciehp_hpc.c:15:22: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'const char *' [-Wformat=]
    #define dev_fmt(fmt) "pciehp: " fmt
                         ^
   include/linux/device.h:1743:17: note: in expansion of macro 'dev_fmt'
     _dev_warn(dev, dev_fmt(fmt), ##__VA_ARGS__)
                    ^~~~~~~
>> include/linux/pci.h:2377:37: note: in expansion of macro 'dev_warn'
    #define pci_warn(pdev, fmt, arg...) dev_warn(&(pdev)->dev, fmt, ##arg)
                                        ^~~~~~~~
>> drivers/pci/hotplug/pciehp.h:42:2: note: in expansion of macro 'pci_warn'
     pci_warn(ctrl->pcie->port, format, ## arg)
     ^~~~~~~~
>> drivers/pci/hotplug/pciehp_hpc.c:568:3: note: in expansion of macro 'ctrl_warn'
      ctrl_warn(ctrl, "Slot(%s): Hot plug event bit stuck, reading %x\n",
      ^~~~~~~~~
   drivers/pci/hotplug/pciehp_hpc.c:568:65: note: format string is defined here
      ctrl_warn(ctrl, "Slot(%s): Hot plug event bit stuck, reading %x\n",
                                                                   ~^
                                                                   %s

vim +15 drivers/pci/hotplug/pciehp_hpc.c

94dbc9562edc74 Frederick Lawler 2019-05-07 @15  #define dev_fmt(fmt) "pciehp: " fmt
94dbc9562edc74 Frederick Lawler 2019-05-07  16  

:::::: The code at line 15 was first introduced by commit
:::::: 94dbc9562edc745d0549f1744ca1bd75e644473e PCI: pciehp: Log messages with pci_dev, not pcie_device

:::::: TO: Frederick Lawler <fred@...dlawl.com>
:::::: CC: Bjorn Helgaas <bhelgaas@...gle.com>

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (70182 bytes)