linux-kernel - Re: [PATCH] ARM: OMAP2+: SmartReflex: add omap_sr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4614865.hGV6RNsBzR@kreacher>
Date:   Wed, 13 Nov 2019 13:16:24 +0100
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Ben Dooks <ben.dooks@...ethink.co.uk>
Cc:     linux-kernel@...ts.codethink.co.uk,
        Kevin Hilman <khilman@...nel.org>, Nishanth Menon <nm@...com>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: OMAP2+: SmartReflex: add omap_sr_pdata definition

On Tuesday, October 15, 2019 3:12:38 PM CET Ben Dooks wrote:
> The omap_sr_pdata is not declared but is exported, so add a
> define for it to fix the following warning:
> 
> arch/arm/mach-omap2/pdata-quirks.c:609:36: warning: symbol 'omap_sr_pdata' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
> ---
> Cc: Kevin Hilman <khilman@...nel.org>
> Cc: Nishanth Menon <nm@...com>
> Cc: linux-pm@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> ---
>  include/linux/power/smartreflex.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/linux/power/smartreflex.h b/include/linux/power/smartreflex.h
> index d0b37e937037..971c9264179e 100644
> --- a/include/linux/power/smartreflex.h
> +++ b/include/linux/power/smartreflex.h
> @@ -293,6 +293,9 @@ struct omap_sr_data {
>  	struct voltagedomain		*voltdm;
>  };
>  
> +
> +extern struct omap_sr_data omap_sr_pdata[OMAP_SR_NR];
> +
>  #ifdef CONFIG_POWER_AVS_OMAP
>  
>  /* Smartreflex module enable/disable interface */
> 

Applied as 5.5 material, thanks!