linux-kernel - Re: [PATCH] perf scripts python: exported-sql-viewer.py: Fix use of TRUE with SQLite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191113125843.GD14646@kernel.org>
Date:   Wed, 13 Nov 2019 09:58:43 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Adrian Hunter <adrian.hunter@...el.com>
Cc:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>,
        Jiri Olsa <jolsa@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf scripts python: exported-sql-viewer.py: Fix use of
 TRUE with SQLite

Em Wed, Nov 13, 2019 at 02:28:24PM +0200, Adrian Hunter escreveu:
> On 13/11/19 2:15 PM, Arnaldo Carvalho de Melo wrote:
> > Em Wed, Nov 13, 2019 at 02:02:06PM +0200, Adrian Hunter escreveu:
> >> Prior to version 3.23 SQLite does not support TRUE or FALSE, so always use
> >> 1 and 0 for SQLite.
> >>
> >> Fixes: 26c11206f433 ("perf scripts python: exported-sql-viewer.py: Use new 'has_calls' column")
> >> Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>
> >> Cc: stable@...r.kernel.org
> > 
> > Thanks, applied and added the first tag with that fixed cset:
> > 
> > Cc: stable@...r.kernel.org # v5.3+
> 
> Thanks, but I just noticed it doesn't apply to 5.3 or 5.4-rc7, sorry :-(.
> I guess the Fixes and stable tags should be dropped and I will send the
> stable patch separately.

Humm, I think this is still appropriate, i.e. the fixes/stables should
not be taken literally as being the patch to apply to those older
versions, just that this patch addresses a problem that was introduced
at that tag and that affects the stable kernels since tag v5.3.

Which in turn makes people try to apply it, if it fails, then the stable
guys ask for guidance.

Of course you can be proactive and do what you say you'll do, i.e. test
it and provide patches for the stable kernels, taking into account
whatever adjustments needed due to this code having been touched after
that problem.

So I'm keeping the fixes and cc stable lines,

Thanks,

- Arnaldo