linux-kernel - Re: [PATCH 1/4] i2c: at91: Use dma_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Nov 2019 13:35:10 +0000
From:   <Ludovic.Desroches@...rochip.com>
To:     <peter.ujfalusi@...com>
CC:     <agross@...nel.org>, <wsa+renesas@...g-engineering.com>,
        <ldewangan@...dia.com>, <vkoul@...nel.org>,
        <linux-i2c@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-arm-msm@...r.kernel.org>, <digetx@...il.com>,
        <linux-tegra@...r.kernel.org>, <thierry.reding@...il.com>,
        <jonathanh@...dia.com>, <Nicolas.Ferre@...rochip.com>,
        <alexandre.belloni@...tlin.com>, <bjorn.andersson@...aro.org>
Subject: Re: [PATCH 1/4] i2c: at91: Use dma_request_chan() directly for
 channel request

On Wed, Nov 13, 2019 at 11:22:32AM +0200, Peter Ujfalusi wrote:
> 
> dma_request_slave_channel_reason() is:
> #define dma_request_slave_channel_reason(dev, name) \
> 	dma_request_chan(dev, name)
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
Acked-by: Ludovic Desroches <ludovic.desroches@...rochip.com> 

Thanks
> ---
>  drivers/i2c/busses/i2c-at91-master.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-at91-master.c b/drivers/i2c/busses/i2c-at91-master.c
> index 6e0b554dcd4e..7a862e00b475 100644
> --- a/drivers/i2c/busses/i2c-at91-master.c
> +++ b/drivers/i2c/busses/i2c-at91-master.c
> @@ -758,14 +758,14 @@ static int at91_twi_configure_dma(struct at91_twi_dev *dev, u32 phy_addr)
>  	slave_config.dst_maxburst = 1;
>  	slave_config.device_fc = false;
>  
> -	dma->chan_tx = dma_request_slave_channel_reason(dev->dev, "tx");
> +	dma->chan_tx = dma_request_chan(dev->dev, "tx");
>  	if (IS_ERR(dma->chan_tx)) {
>  		ret = PTR_ERR(dma->chan_tx);
>  		dma->chan_tx = NULL;
>  		goto error;
>  	}
>  
> -	dma->chan_rx = dma_request_slave_channel_reason(dev->dev, "rx");
> +	dma->chan_rx = dma_request_chan(dev->dev, "rx");
>  	if (IS_ERR(dma->chan_rx)) {
>  		ret = PTR_ERR(dma->chan_rx);
>  		dma->chan_rx = NULL;
> -- 
> Peter
> 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
> 
>