linux-kernel - Re: [EXT] Re: [PATCH 4/5] media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encoder/Decoder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <152f7b2bef85cec9ef107b58ba0bac153fde1379.camel@pengutronix.de>
Date:   Wed, 13 Nov 2019 16:13:36 +0100
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Mirela Rabulea <mirela.rabulea@....com>,
        "ezequiel@...labora.com" <ezequiel@...labora.com>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>
Cc:     dl-linux-imx <linux-imx@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "laurent.pinchart+renesas@...asonboard.com" 
        <laurent.pinchart+renesas@...asonboard.com>,
        Aisheng Dong <aisheng.dong@....com>,
        Laurentiu Palcu <laurentiu.palcu@....com>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "paul.kocialkowski@...tlin.com" <paul.kocialkowski@...tlin.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Robert Chiras <robert.chiras@....com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "niklas.soderlund+renesas@...natech.se" 
        <niklas.soderlund+renesas@...natech.se>,
        "hverkuil-cisco@...all.nl" <hverkuil-cisco@...all.nl>,
        Daniel Baluta <daniel.baluta@....com>,
        Leonard Crestez <leonard.crestez@....com>,
        "dafna.hirschfeld@...labora.com" <dafna.hirschfeld@...labora.com>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>
Subject: Re: [EXT] Re: [PATCH 4/5] media: imx-jpeg: Add V4L2 driver for
 i.MX8 JPEG Encoder/Decoder

Hi Ezequiel, Mirela,

On Wed, 2019-11-13 at 14:59 +0000, Mirela Rabulea wrote:
> Hi Ezequiel,
> On Mi, 2019-11-13 at 11:00 -0300, Ezequiel Garcia wrote:
> > + * default configuration stream, 64x64 yuv422
> > > + * split by JPEG marker, so it's easier to modify & use
> > > + */
> > > +static const unsigned char jpeg_soi[] = {0xFF, 0xD8};
> > > +static const unsigned char jpeg_app0[] = {0xFF, 0xE0,
> > I think it's time to re-consider creating some common code
> > for drivers that deal with JPEG parsing. I don't know
> > exactly how this should be done, but it's worth a try.
> > 
> > Having been there, it might sound unfair to request you to
> > take such action. However, someone has to do these kinds
> > of cleanups and improvements, sooner or later, if we want
> > to keep a clean codebase.
> > 
> > Hope this makes sense.
> 
> I agree, it makes sense, at least the jpeg parsing is somehow common
> between these drivers. I'm willing to contribute to this, but I cannot
> make a promise when, and this is something that requires collaboration
> with other contributors who have the means to validate changes on all
> the hardware affected.

I just faced the same issue for the coda-vpu driver [1]. I wonder if my
approach would be usable as a base for i.MX8 JPEGDEC as well. Either
way, I'd like to collaborate on this, but I can't test most of the
drivers either.

[1] https://patchwork.linuxtv.org/patch/60109/

regards
Philipp