linux-kernel - Re: [alsa-devel] [PATCH v6 5/8] ALSA: Avoid using timespec for struct snd_rawmidi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a1gJAjyNK4R3k560VjC+sN=haWjhEX4SpgroRoMDQANiA@mail.gmail.com>
Date:   Wed, 13 Nov 2019 16:16:26 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     ALSA Development Mailing List <alsa-devel@...a-project.org>,
        Takashi Iwai <tiwai@...e.com>,
        Baolin Wang <baolin.wang@...aro.org>,
        y2038 Mailman List <y2038@...ts.linaro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Mark Brown <broonie@...nel.org>,
        Baolin Wang <baolin.wang7@...il.com>
Subject: Re: [alsa-devel] [PATCH v6 5/8] ALSA: Avoid using timespec for struct snd_rawmidi_status

On Tue, Nov 12, 2019 at 9:26 PM Takashi Iwai <tiwai@...e.de> wrote:
> On Tue, 12 Nov 2019 21:04:10 +0100, Arnd Bergmann wrote:
> >
> > On Tue, Nov 12, 2019 at 5:38 PM Takashi Iwai <tiwai@...e.de> wrote:
> > > On Tue, 12 Nov 2019 16:16:39 +0100, Arnd Bergmann wrote:
> > If you feel there is a problem with the padding syntax, how about enclosing
> > it in a typedef like:
> >
> > typedef struct { char pad[sizeof(time_t) - sizeof(int)]; } __time_pad;
> >
> > This typedef could be used in several structures from the other patches
> > as well.
>
> Yes, that improves the readability.

Ok, added this change to all instances, along with a description in
the changelog
when I add the typedef.

       Arnd