linux-kernel - Re: [PATCH 3/3] arm64: dts: rk3399: Add init voltage for vdd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=UjbPALRU2r0s27F4RxjsbDyQ+horUBezVQejk1pT=vqA@mail.gmail.com>
Date:   Wed, 13 Nov 2019 09:01:16 -0800
From:   Doug Anderson <dianders@...omium.org>
To:     Kever Yang <kever.yang@...k-chips.com>
Cc:     Heiko Stübner <heiko@...ech.de>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
        Elaine Zhang <zhangqing@...k-chips.com>,
        Peter Robinson <pbrobinson@...il.com>,
        Akash Gajjar <akash@...nedev.com>,
        Alexis Ballier <aballier@...too.org>,
        Andrius Štikonas <andrius@...konas.eu>,
        Andy Yan <andyshrk@...il.com>,
        Ezequiel Garcia <ezequiel@...labora.com>,
        Hugh Cole-Baker <sigmaris@...il.com>,
        Katsuhiro Suzuki <katsuhiro@...suster.net>,
        Mark Rutland <mark.rutland@....com>,
        Nick Xie <nick@...das.com>,
        Oskari Lemmela <oskari@...mela.net>,
        Pragnesh Patel <Pragnesh_Patel@...tor.com>,
        Rob Herring <robh+dt@...nel.org>,
        Robin Murphy <robin.murphy@....com>,
        Soeren Moch <smoch@....de>, Vicente Bergas <vicencb@...il.com>,
        Vivek Unune <npcomplete13@...il.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] arm64: dts: rk3399: Add init voltage for vdd_log

Hi,

On Sun, Nov 10, 2019 at 4:52 PM Kever Yang <kever.yang@...k-chips.com> wrote:
>
> Since there is no devfreq used for vdd_log, so the vdd_log(pwm regulator)
> will be 'enable' with the dts node at a default PWM state with high or low
> output. Both too high or too low for vdd_log is not good for the board,
> add init voltage for driver to make the regulator get into a know output.
>
> Note that this will be used by U-Boot for init voltage output, and this
> is very important for it may get system hang somewhere during system
> boot up with regulator enable and without this init value.

I'm a tad bit confused here.  When U-Boot boots the kernel, how is the
PWM configured?

I remember folks going through a lot of work to make sure that we
could actually _read_ the PWM state that the bootloader gave us and
report it as the initial voltage.  If the kernel ends up needing to
configure the PWM regulator's period for some reason, I remember it
would actually pick something close.  Is that not working for you?

For instance, on rk3288-veyron when I boot up mainline (no devfreq on
rk3288-veyron on mainline) the vdd_logic reports 1.2 volts because it
read what the bootloader left it as.

...are you saying that U-Boot doesn't configure the PWM and you're
trying to fix it up in the kernel?

-Doug


-Doug