linux-kernel - Re: [PATCH] drm/bridge: ti-tfp410: switch to using fwnode_gpiod_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191113172555.GW23790@phenom.ffwll.local>
Date:   Wed, 13 Nov 2019 18:25:55 +0100
From:   Daniel Vetter <daniel@...ll.ch>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Daniel Vetter <daniel@...ll.ch>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...l.net>,
        David Airlie <airlied@...ux.ie>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        "open list:DRM PANEL DRIVERS" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/bridge: ti-tfp410: switch to using
 fwnode_gpiod_get_index()

On Wed, Nov 13, 2019 at 02:52:23PM +0100, Linus Walleij wrote:
> On Tue, Nov 5, 2019 at 4:41 PM Daniel Vetter <daniel@...ll.ch> wrote:
> > On Tue, Nov 5, 2019 at 4:29 PM Linus Walleij <linus.walleij@...aro.org> wrote:
> > > On Tue, Nov 5, 2019 at 1:40 AM Dmitry Torokhov
> > > <dmitry.torokhov@...il.com> wrote:
> 
> > > I'm happy to merge it into the GPIO tree if some DRM maintainer can
> > > provide an ACK.
> >
> > Ack.
> 
> Thanks!
> 
> > > Getting ACK from DRM people is problematic and a bit of friction in the
> > > community, DVetter usually advice to seek mutual reviews etc, but IMO
> > > it would be better if some people felt more compelled to review stuff
> > > eventually. (And that has the problem that it doesn't scale.)
> >
> > This has a review already plus if you merge your implied review.
> 
> Yeah I missed Laurent's review tag. I needed some kund of consent
> to take it into the GPIO tree I suppose.
> 
> > That's more than good enough imo, so not seeing the issue here?
> 
> No issue.
> 
> What freaked me out was the option of having to pull in an
> immutable branch from my GPIO tree into drm-misc. That would
> have been scary. Keeping it all in my tree works fine.

For next time around, just ping one of the drm-misc (or drm maintainers)
for an ack to merge it through a different tree. Or ask them what they
want to do. committer model isn't 100% free-wheeling, for cross-tree stuff
you still have maintainers who're supposed to do their jobs :-)

But by default everyone will assume you'll just commit, so you need to
poke them explicitly (like you've done here).
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch