Message-ID: <587b0adf-b71d-6fde-407b-46089ed5d695@synopsys.com>
Date:   Wed, 13 Nov 2019 19:14:59 +0000
From:   Thinh Nguyen <Thinh.Nguyen@...opsys.com>
To:     Alan Stern <stern@...land.harvard.edu>,
        Michael Olbrich <m.olbrich@...gutronix.de>
CC:     Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        Felipe Balbi <balbi@...nel.org>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>
Subject: Re: [PATCH 2/2] usb: dwc3: gadget: restart the transfer if a isoc
 request is queued too late

Hi Michael,

Alan Stern wrote:
> On Wed, 13 Nov 2019, Michael Olbrich wrote:
>
>> On Wed, Nov 13, 2019 at 03:55:01AM +0000, Thinh Nguyen wrote:
>>> Michael Olbrich wrote:
>>>> Currently, most gadget drivers handle isoc transfers on a best effort
>>>> bases: If the request queue runs empty, then there will simply be gaps in
>>>> the isoc data stream.
>>>>
>>>> The UVC gadget depends on this behaviour. It simply provides new requests
>>>> when video frames are available and assumes that they are sent as soon as
>>>> possible.
>>>>
>>>> The dwc3 gadget currently works differently: It assumes that there is a
>>>> contiguous stream of requests without any gaps. If a request is too late,
>>>> then it is dropped by the hardware.
>>>> For the UVC gadget this means that a live stream stops after the first
>>>> frame because all following requests are late.
>>> Can you explain little more how UVC gadget fails?
>>> dwc3 controller expects a steady stream of data otherwise it will result
>>> in missed_isoc status, and it should be fine as long as new requests are
>>> queued. The controller doesn't just drop the request unless there's some
>>> other failure.
>> UVC (with a live stream) does not fill the complete bandwidth of an
>> isochronous endpoint. Let's assume for the example that one video frame
>> fills 3 requests. Because it is a live stream, there will be a gap between
>> video frames. This is unavoidable, especially for compressed video. So the
>> UVC gadget will have requests for the frame numbers 1 2 3 5 6 7 9 10 11 13 14
>> 15 and so on.
>> The dwc3 hardware tries to send those with frame numbers 1 2 3 4 5 6 7 8 9
>> 10 11 12. So except for the fist few requests, all are late and result in a
>> missed_isoc. I tried to just ignore the missed_isoc but that did not work
>> for me. I only received the first frame at the other end.
>> Maybe I missing something here, i don't have access to the hardware
>> documentation, so I can only guess from the existing driver.

The reason I asked is because your patch doesn't seem to address the 
actual issue.

For the 2 checks you do here
1. There are currently no requests queued in the hardware
2. The current frame number provided by DSTS does not match the frame
     number returned by the last transfer.

For #1, it's already done in the dwc3 driver. (check 
dwc3_gadget_endpoint_transfer_in_progress())
For #2, it's unlikely that DSTS current frame number will match with the 
XferNotReady's frame number. So this check doesn't mean much.

So I'm still wondering how does this patch help resolve your issue.

> How about changing the gadget driver instead?  For frames where the UVC
> gadget knows no video frame data is available (numbers 4, 8, 12, and so
> on in the example above), queue a zero-length request.  Then there
> won't be any gaps in the isochronous packet stream.
>
> Alan Stern

What Alan suggests may work. Have you tried this?

BR,
Thinh

Powered by blists - more mailing lists