linux-kernel - Re: [PATCH][V3] ovl: fix lookup failure on multi lower squashfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOQ4uxjrON7FvEgOUvKP8DoHfbVY+LxinTMa=uAeHwAp=--zuw@mail.gmail.com>
Date:   Wed, 13 Nov 2019 21:29:05 +0200
From:   Amir Goldstein <amir73il@...il.com>
To:     Colin Ian King <colin.king@...onical.com>
Cc:     Miklos Szeredi <mszeredi@...hat.com>,
        overlayfs <linux-unionfs@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][V3] ovl: fix lookup failure on multi lower squashfs

> > Sorry I wasn't clear.
> > Miklos is right. the test ofs->upper_mnt here is bogus because
> > nfs_export could be enabled without upper.
> > The change you made in v3 to ovl_lower_uuid_ok() should be enough.
>
> OK, so the following is required for V4:
>
> +       if (!ovl_lower_uuid_ok(ofs, &sb->s_uuid)) {
>

Yes. more accurately there should be no change to this line.

Thanks,
Amir.