linux-kernel - Re: [PATCH AUTOSEL 4.14 014/115] ata: ahci_brcm: Match BCM63138 compatible strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bcd8f736-34a7-b0bb-adc1-1f7a092fc1f5@gmail.com>
Date:   Wed, 13 Nov 2019 12:07:25 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Sasha Levin <sashal@...nel.org>, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Cc:     Jens Axboe <axboe@...nel.dk>, linux-ide@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 4.14 014/115] ata: ahci_brcm: Match BCM63138
 compatible strings

On 11/12/19 5:54 PM, Sasha Levin wrote:
> From: Florian Fainelli <f.fainelli@...il.com>
> 
> [ Upstream commit fb8506f15f2e394f5f648575cf48a26e8744390c ]
> 
> Match the "brcm,bcm63138-ahci" compatible string in order to allow this
> driver to probe on such platforms.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> Signed-off-by: Jens Axboe <axboe@...nel.dk>
> Signed-off-by: Sasha Levin <sashal@...nel.org>

This is a feature and not really a bug fix, is someone specifically
asking for this to be back ported? Also without the matching SATA PHY
driver changes:

7b69fa1c5c930886f8a916cc47096dd4044c007a ("phy: brcm-sata: Add BCM63138
(DSL) PHY init sequence")

this is pretty useless on its own. Same applies to all automatic
selections, not just this kernel obviously.

> ---
>  drivers/ata/ahci_brcm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ata/ahci_brcm.c b/drivers/ata/ahci_brcm.c
> index 5936d1679bf3a..0a3998526bb1d 100644
> --- a/drivers/ata/ahci_brcm.c
> +++ b/drivers/ata/ahci_brcm.c
> @@ -297,6 +297,7 @@ static struct scsi_host_template ahci_platform_sht = {
>  static const struct of_device_id ahci_of_match[] = {
>  	{.compatible = "brcm,bcm7425-ahci", .data = (void *)BRCM_SATA_BCM7425},
>  	{.compatible = "brcm,bcm7445-ahci", .data = (void *)BRCM_SATA_BCM7445},
> +	{.compatible = "brcm,bcm63138-ahci", .data = (void *)BRCM_SATA_BCM7445},
>  	{.compatible = "brcm,bcm-nsp-ahci", .data = (void *)BRCM_SATA_NSP},
>  	{},
>  };
> 


-- 
Florian