linux-kernel - Re: [tcp] f859a44847: stderr.fastopen-client.pkt:#:runtime_error_in_sendto_call:Expected_result#but_got-#with_errno#(Operation_now_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 13 Nov 2019 16:02:31 -0500
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     kernel test robot <rong.a.chen@...el.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        lkp@...ts.01.org
Subject: Re: [tcp] f859a44847: stderr.fastopen-client.pkt:#:runtime_error_in_sendto_call:Expected_result#but_got-#with_errno#(Operation_now_in_progress)

On Tue, Nov 12, 2019 at 10:04 PM kernel test robot
<rong.a.chen@...el.com> wrote:
>
> FYI, we noticed the following commit (built with gcc-7):
>
> commit: f859a448470304135f7a1af0083b99e188873bb4 ("tcp: allow zerocopy with fastopen")
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
>
> in testcase: packetdrill
> with following parameters:
>
>
> on test machine: qemu-system-x86_64 -enable-kvm -cpu SandyBridge -smp 2 -m 8G
>
> caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):

The report shows the complete output of a complete packetdrill run.
>From that it is not immediately obvious which packetdrill test output
changed.

The subject line calls out tcp/zerocopy/fastopen-client.pkt. The
result of that test are expected to change with this commit
f859a4484703 ("tcp: allow zerocopy with fastopen"), because this test
was added exactly to verify the feature introduced with that commit.

The report shows this specific test passing for ipv4 and
ipv4-mapped-v6. I cannot explain why that run failed for ipv6. On my
runs all three pass at this commit:

  $ git clone https://github.com/google/packetdrill
  $ cd packetdrill/gtests/net
  $ (cd packetdrill; make)
  $ ./packetdrill/run_all.py tcp/zerocopy
  Ran   33 tests:   33 passing,    0 failing,    0 timed out (7.28
sec): tcp/zerocopy

and fail on the previous commit, along with all three versions of
fastopen-server.pkt and closed.pkt:

  $ ./packetdrill/run_all.py tcp/zerocopy
  Ran   33 tests:   24 passing,    9 failing,    0 timed out (7.22
sec): tcp/zerocopy

All this is expected, so there is nothing to fix for this report.

This was on a kernel built with `make defconfig; make kvmconfig` and
additionally CONFIG_TUN=y. Though those details should be immaterial
here.

Great that the test robot is running packetdrill tests, btw! Good to
know we upstreamed them for a reason.

But how did it end up testing such an old kernel? This commit was added in 5.1.