linux-kernel - Re: [PATCH resend] libtraceevent: fix parsing event argument types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191113161754.47bf2c36@gandalf.local.home>
Date:   Wed, 13 Nov 2019 16:17:54 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
Cc:     Arnaldo Carvalho de Melo <acme@...hat.com>,
        linux-kernel@...r.kernel.org,
        Tzvetomir Stoyanov <tz.stoyanov@...il.com>
Subject: Re: [PATCH resend] libtraceevent: fix parsing event argument types

On Sun, 10 Nov 2019 13:11:01 +0300
Konstantin Khlebnikov <khlebnikov@...dex-team.ru> wrote:

> Add missing "%o" and "%X". Ext4 events use "%o" for printing i_mode.

Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

Arnaldo, can you take this?

Thanks! (this time I mean it ;)

-- Steve

> 
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@...dex-team.ru>
> ---
>  tools/lib/traceevent/event-parse.c |    7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
> index d948475585ce..beaa8b8c08ff 100644
> --- a/tools/lib/traceevent/event-parse.c
> +++ b/tools/lib/traceevent/event-parse.c
> @@ -4395,8 +4395,10 @@ static struct tep_print_arg *make_bprint_args(char *fmt, void *data, int size, s
>  				/* fall through */
>  			case 'd':
>  			case 'u':
> -			case 'x':
>  			case 'i':
> +			case 'x':
> +			case 'X':
> +			case 'o':
>  				switch (ls) {
>  				case 0:
>  					vsize = 4;
> @@ -5078,10 +5080,11 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct tep_e
>  
>  				/* fall through */
>  			case 'd':
> +			case 'u':
>  			case 'i':
>  			case 'x':
>  			case 'X':
> -			case 'u':
> +			case 'o':
>  				if (!arg) {
>  					do_warning_event(event, "no argument match");
>  					event->flags |= TEP_EVENT_FL_FAILED;