linux-kernel - Re: [Outreachy kernel] Re: [PATCH 5/9] staging: rtl8723bs: Add necessary braces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191113002248.u4cwx7bwjenpzwbj@gmail.com>
Date:   Tue, 12 Nov 2019 19:22:48 -0500
From:   "Javier F. Arias" <jarias.linux@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, outreachy-kernel@...glegroups.com
Subject: Re: [Outreachy kernel] Re: [PATCH 5/9] staging: rtl8723bs: Add
 necessary braces

Hello Greg,

The unbalanced braces were fixed in the patch #6. I thought that
given that Checkpatch detects them as different issues I could only
change single lines and fix the unbalanced ones in the next patch.

I'll edit the patches then.

On Wed, Nov 13, 2019 at 12:04:05AM +0100, Greg KH wrote:
> On Tue, Nov 12, 2019 at 11:54:32AM -0500, Javier F. Arias wrote:
> > This patchset adds braces when they should be used on all arms of
> > the statement.
> > Issue found by Checkpatch.
> > 
> > Signed-off-by: Javier F. Arias <jarias.linux@...il.com>
> > ---
> >  drivers/staging/rtl8723bs/core/rtw_xmit.c | 31 +++++++++++++++--------
> >  1 file changed, 20 insertions(+), 11 deletions(-)
> > 
> > diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
> > index fdb585ff5925..42bd5d8362fa 100644
> > --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
> > +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
> > @@ -370,8 +370,9 @@ static void update_attrib_vcs_info(struct adapter *padapter, struct xmit_frame *
> >  	/* 		Other fragments are protected by previous fragment. */
> >  	/* 		So we only need to check the length of first fragment. */
> >  	if (pmlmeext->cur_wireless_mode < WIRELESS_11_24N  || padapter->registrypriv.wifi_spec) {
> > -		if (sz > padapter->registrypriv.rts_thresh)
> > +		if (sz > padapter->registrypriv.rts_thresh) {
> >  			pattrib->vcs_mode = RTS_CTS;
> > +		}
> >  		else {
> 
> The } should be on the same line as the "else {"
> 
> thanks,
> 
> greg k-h
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191112230405.GA1904763%40kroah.com.