linux-kernel - Re: [PATCH -next] scsi: ufshcd: Remove dev_err() on platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1y2wkpkwh.fsf@oracle.com>
Date:   Tue, 12 Nov 2019 21:31:10 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     <alim.akhtar@...sung.com>, <avri.altman@....com>,
        <pedrom.sousa@...opsys.com>, <jejb@...ux.ibm.com>,
        <martin.petersen@...cle.com>, <stanley.chu@...iatek.com>,
        <arnd@...db.de>, <linux-scsi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] scsi: ufshcd: Remove dev_err() on platform_get_irq() failure


YueHaibing,

> platform_get_irq() will call dev_err() itself on failure, so there is
> no need for the driver to also do this.  This is detected by
> coccinelle.

Applied to 5.5/scsi-queue, thanks.

-- 
Martin K. Petersen	Oracle Linux Engineering