linux-kernel - Re: [PATCH v3 1/5] scsi: Adjust DBD setting in mode sense for caching mode page per LLD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a7e85a27f08d571b6c70421784d6fd05@codeaurora.org>
Date:   Wed, 13 Nov 2019 11:22:25 +0800
From:   cang@...eaurora.org
To:     "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     asutoshd@...eaurora.org, nguyenb@...eaurora.org,
        rnayak@...eaurora.org, linux-scsi@...r.kernel.org,
        kernel-team@...roid.com, saravanak@...gle.com, salyzyn@...gle.com,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        linux-kernel@...r.kernel.org, Can Guo <cang@...eaurora.org>
Subject: Re: [PATCH v3 1/5] scsi: Adjust DBD setting in mode sense for caching
 mode page per LLD

On 2019-11-13 11:03, Martin K. Petersen wrote:
> Can,
> 
>> Host sends MODE_SENSE_10 with caching mode page, to check if the
>> device supports the cache feature.  UFS JEDEC standards require DBD
>> field to be set to 1.
> 
> UFS requires DBD for all MODE SENSE(10) invocations, not just for
> accessing the caching mode page. I think the flag name needs to reflect
> this.
> 
> Also, I do not particularly like this being a scsi_host flag. All the
> other flags we have in this department are per scsi_device.
> 
> My recommendation would be to add a set_dbd_for_ms flag to struct
> scsi_device and then do:
> 
> 	sdev->set_dbd_for_ms = 1;
> 
> in ufshcd_slave_alloc() mirroring the existing:
> 
>         sdev->use_10_for_ms = 1;
> 
> This makes the MODE SENSE tweakery consistent.
> 
> Thanks!

Hi Martin,

Thank you, good idea. I will make the change in your way.

Best regards,
Can Guo.