linux-kernel - Re: [PATCH 2/2] pinctrl: Use new GPIO_LINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Nov 2019 14:30:05 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
Cc:     kbuild-all@...ts.01.org, matti.vaittinen@...rohmeurope.com,
        mazziesaccount@...il.com, Linus Walleij <linus.walleij@...aro.org>,
        Eric Anholt <eric@...olt.net>,
        Stefan Wahren <wahrenst@....net>,
        Florian Fainelli <f.fainelli@...il.com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com,
        Sean Wang <sean.wang@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Jason Cooper <jason@...edaemon.net>,
        Andrew Lunn <andrew@...n.ch>,
        Gregory Clement <gregory.clement@...tlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Paul Cercueil <paul@...pouillou.net>,
        Neil Armstrong <narmstrong@...libre.com>,
        Heiko Stuebner <heiko@...ech.de>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Patrice Chotard <patrice.chotard@...com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        linux-gpio@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-mediatek@...ts.infradead.org, linux-oxnas@...ups.io,
        linux-rockchip@...ts.infradead.org,
        linux-renesas-soc@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 2/2] pinctrl: Use new GPIO_LINE_DIRECTION

Hi Matti,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on 70d97e099bb426ecb3ad4bf31e88dbf2ef4b2e4c]

url:    https://github.com/0day-ci/linux/commits/Matti-Vaittinen/pinctrl-rza1-remove-unnecerssary-static-inline-function/20191113-114104
base:    70d97e099bb426ecb3ad4bf31e88dbf2ef4b2e4c
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from drivers/pinctrl/vt8500/pinctrl-wmt.c:9:0:
   drivers/pinctrl/vt8500/pinctrl-wmt.c: In function 'wmt_gpio_get_direction':
   include/linux/gpio/driver.h:26:33: warning: statement with no effect [-Wunused-value]
    #define GPIO_LINE_DIRECTION_OUT 0
                                    ^
>> drivers/pinctrl/vt8500/pinctrl-wmt.c:490:3: note: in expansion of macro 'GPIO_LINE_DIRECTION_OUT'
      GPIO_LINE_DIRECTION_OUT;
      ^~~~~~~~~~~~~~~~~~~~~~~

vim +/GPIO_LINE_DIRECTION_OUT +490 drivers/pinctrl/vt8500/pinctrl-wmt.c

   479	
   480	static int wmt_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
   481	{
   482		struct wmt_pinctrl_data *data = gpiochip_get_data(chip);
   483		u32 bank = WMT_BANK_FROM_PIN(offset);
   484		u32 bit = WMT_BIT_FROM_PIN(offset);
   485		u32 reg_dir = data->banks[bank].reg_dir;
   486		u32 val;
   487	
   488		val = readl_relaxed(data->base + reg_dir);
   489		if (val & BIT(bit))
 > 490			GPIO_LINE_DIRECTION_OUT;
   491	
   492		return GPIO_LINE_DIRECTION_IN;
   493	}
   494	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (71989 bytes)