linux-kernel - Re: [PATCH] vboxsf: move out of staging to fs/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f7e11836-8f90-4ddf-1c81-4d49d35d91d6@redhat.com>
Date:   Wed, 13 Nov 2019 09:03:53 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Christoph Hellwig <hch@...radead.org>,
        devel@...uxdriverproject.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        David Howells <dhowells@...hat.com>
Subject: Re: [PATCH] vboxsf: move out of staging to fs/

Hi,

On 13-11-2019 00:12, Linus Torvalds wrote:
> On Tue, Nov 12, 2019 at 2:54 PM Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
>>
>> Christoph, this is what you mean, right?  If so, I'll send this to Linus
>> later this week, or he can grab it right from this patch :)
> 
> No.
> 
> I was unhappy about a staging driver being added in rc7, but I went
> "whatever, it's Greg's garbage"
> 
> There is no way in hell I will take a new filesystem in rc8.
> 
> Would you take that into stable? No, you wouldn't. Then why is this
> being upstreamed now.
> 
> Honestly, I think I'll just delete the whole thing, since it shouldn't
> have gone in in the first place. This is not how we add new
> filesystems.

I understand you being unhappy with this.

The problem is that Al Viro, after an initial review around v2 or v3 of
the patch, which I believe I have fully addressed, has been ignoring
this patch / new fs for over a year now. I've pinged him repeatedly
both via email and on irc, but with no luck.  I guess he simply is
too busy with other stuff.

I did ask other fs developers to review and have gotten reviews
from David Howell and Christoph Hellwig. I've addressed all their
review remarks and I've had reviews of the newer versions with
just a few nitpicks remaining. I've also addressed those nitpicks.
But I never got an Acked-by or Reviewed-by from either of them
on any of the newer versions.

I even talked to various people about this at plumbers, but
I did not get any traction there either.

On the advice of Christoph I've asked Andrew Morton to take this
directly under fs/ instead, twice. When this all went no where I
went the staging route, with the current result.

So for 5.5, and assuming I can get David's and/or Christoph's
Acked-by, is is ok if I send this directly to you?

Regards,

Hans

p.s.

Christoph, David, can I get your Acked-by for the latest
version of the patch (v17) ?