linux-kernel - RE: [PATCH 1/3] iio: Add ADM1177 Hot Swap Controller and Digital Power Monitor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY5PR03MB4965158557D9AEA20A48F95F8E760@BY5PR03MB4965.namprd03.prod.outlook.com>
Date:   Wed, 13 Nov 2019 08:10:50 +0000
From:   "Hennerich, Michael" <Michael.Hennerich@...log.com>
To:     Guenter Roeck <linux@...ck-us.net>,
        Jonathan Cameron <jonathan.cameron@...wei.com>
CC:     "Bia, Beniamin" <Beniamin.Bia@...log.com>,
        "jic23@...nel.org" <jic23@...nel.org>,
        "lars@...afoo.de" <lars@...afoo.de>,
        "pmeerw@...erw.net" <pmeerw@...erw.net>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "paulmck@...ux.ibm.com" <paulmck@...ux.ibm.com>,
        "mchehab+samsung@...nel.org" <mchehab+samsung@...nel.org>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "nicolas.ferre@...rochip.com" <nicolas.ferre@...rochip.com>,
        "biabeniamin@...look.com" <biabeniamin@...look.com>,
        Jean Delvare <jdelvare@...e.com>
Subject: RE: [PATCH 1/3] iio: Add ADM1177 Hot Swap Controller and Digital
 Power Monitor driver



> -----Original Message-----
> From: Guenter Roeck <groeck7@...il.com> On Behalf Of Guenter Roeck
> Sent: Dienstag, 12. November 2019 20:18
> To: Jonathan Cameron <jonathan.cameron@...wei.com>
> Cc: Bia, Beniamin <Beniamin.Bia@...log.com>; jic23@...nel.org;
> lars@...afoo.de; Hennerich, Michael <Michael.Hennerich@...log.com>;
> pmeerw@...erw.net; gregkh@...uxfoundation.org; linux-
> iio@...r.kernel.org; devel@...verdev.osuosl.org; linux-
> kernel@...r.kernel.org; mark.rutland@....com; robh+dt@...nel.org;
> devicetree@...r.kernel.org; paulmck@...ux.ibm.com;
> mchehab+samsung@...nel.org; linus.walleij@...aro.org;
> nicolas.ferre@...rochip.com; biabeniamin@...look.com; Jean Delvare
> <jdelvare@...e.com>
> Subject: Re: [PATCH 1/3] iio: Add ADM1177 Hot Swap Controller and Digital
> Power Monitor driver
> 
> On Tue, Nov 12, 2019 at 05:37:57PM +0000, Jonathan Cameron wrote:
> > On Tue, 12 Nov 2019 17:35:50 +0200
> > Beniamin Bia <beniamin.bia@...log.com> wrote:
> >
> > > From: Michael Hennerich <michael.hennerich@...log.com>
> > >
> > > ADM1177 is a Hot Swap Controller and Digital Power Monitor with Soft
> > > Start Pin.
> > >
> > > Datasheet:
> > > Link:
> > > https://www.analog.com/media/en/technical-documentation/data-
> sheets/
> > > ADM1177.pdf
> > >
> > > Signed-off-by: Michael Hennerich <michael.hennerich@...log.com>
> > > Co-developed-by: Beniamin Bia <beniamin.bia@...log.com>
> > > Signed-off-by: Beniamin Bia <beniamin.bia@...log.com>
> >
> > Hi Beniamin,
> >
> > A couple immediate thoughts.
> >
> > 1. That cc list has some rather non obvious people on it.  Unless something
> >    fairly surprising is going on, probably better to cut it back a bit.
> >
> > 2. Why IIO?  Not entirely obvious to me.  From first glance this is definitely
> >    doing hardware monitoring.  If there is a reason there should be a clear
> >    statement here on why.
> >
> 
> I don't see why this is implemented as iio driver. I think it should be
> implemented as hardware monitoring driver.

Totally agree that this driver could have been implemented as HWMON driver.
Well we use this device as USB supply monitor on our embedded portably kits, to detect low VBUS or excess current draw. 

ADALM-PLUTO and ADALM2000:
https://www.analog.com/en/design-center/evaluation-hardware-and-software/evaluation-boards-kits/adalm-pluto.html

https://www.analog.com/en/design-center/evaluation-hardware-and-software/evaluation-boards-kits/ADALM2000.html

The only connectivity to the host PC is via IIO/libiio USB Gadget FS and Ethernet backends.

We recommend people to read the IIO attributes whenever they report an issue.
Unless libiio supports directly HWMON or HWMON adds an IIO bridge we would prefer this driver being exposed as IIO device, since HWMON users still can use the IIO/HWMON bridge.

-Michael