linux-kernel - Re: [PATCH] ASoC: wm8904: fix regcache handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191113082515.GE10439@ediswmail.ad.cirrus.com>
Date:   Wed, 13 Nov 2019 08:25:15 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Michael Walle <michael@...le.cc>
CC:     <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, <patches@...nsource.cirrus.com>
Subject: Re: [PATCH] ASoC: wm8904: fix regcache handling

On Tue, Nov 12, 2019 at 11:36:29PM +0100, Michael Walle wrote:
> The current code assumes that the power is turned off in
> SND_SOC_BIAS_OFF. If there are no actual regulator the codec isn't
> turned off and the registers are not reset to their default values but
> the regcache is still marked as dirty. Thus a value might not be written
> to the hardware if it is set to the default value. Do a software reset
> before turning off the power to make sure the registers are always reset
> to their default states.
> 
> Signed-off-by: Michael Walle <michael@...le.cc>
> ---

Acked-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles