linux-kernel - Re: [patch V2 09/16] x86/ioperm: Move TSS bitmap update to exit to user work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191113083014.GD4131@hirez.programming.kicks-ass.net>
Date:   Wed, 13 Nov 2019 09:30:14 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Andy Lutomirski <luto@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>, X86 ML <x86@...nel.org>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Willy Tarreau <w@....eu>, Juergen Gross <jgross@...e.com>,
        Sean Christopherson <sean.j.christopherson@...el.com>,
        "H. Peter Anvin" <hpa@...or.com>
Subject: Re: [patch V2 09/16] x86/ioperm: Move TSS bitmap update to exit to
 user work

On Tue, Nov 12, 2019 at 09:46:30AM -0800, Linus Torvalds wrote:

> I think it's just that the pattern to find "start of new function" is
> confused by the "__visible" or something.
> 
> Don't rely too much on the function names in the diff headers. They
> can be confused by labels, or just by other things. I think it ends up
> being "does the line start with alphabetic character" that is the
> heuristic for "this is a function header".

Right, so I have this in my .gitconfig:

[diff "default"]
	xfuncname = "^[[:alpha:]$_].*[^:]$"

Which works nice for C in that it will no longer accept labels as
funcname, but it stinks for ASM :-)