linux-kernel - Re: [PATCH 4.19 097/125] perf/x86/uncore: Fix event group support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191113103531.GB32553@amd>
Date:   Wed, 13 Nov 2019 11:35:31 +0100
From:   Pavel Machek <pavel@...x.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Kan Liang <kan.liang@...ux.intel.com>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Mark Rutland <mark.rutland@....com>,
        Namhyung Kim <namhyung@...nel.org>,
        Stephane Eranian <eranian@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Vince Weaver <vincent.weaver@...ne.edu>,
        linux-drivers-review@...ists.intel.com,
        linux-perf@...ists.intel.com, Ingo Molnar <mingo@...nel.org>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 4.19 097/125] perf/x86/uncore: Fix event group support

Hi!

>  	return ret;
>  }
>  
> +static void uncore_pmu_enable(struct pmu *pmu)
> +{
> +	struct intel_uncore_pmu *uncore_pmu;
> +	struct intel_uncore_box *box;
> +
> +	uncore_pmu = container_of(pmu, struct intel_uncore_pmu, pmu);
> +	if (!uncore_pmu)
> +		return;

AFAICT this test can never trigger.

> +static void uncore_pmu_disable(struct pmu *pmu)
> +{
> +	struct intel_uncore_pmu *uncore_pmu;
> +	struct intel_uncore_box *box;
> +
> +	uncore_pmu = container_of(pmu, struct intel_uncore_pmu, pmu);
> +	if (!uncore_pmu)
> +		return;

And neither can this one.

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)