linux-kernel - Re: [PATCH] irqchip/ti-sci-inta: Use ERR_CAST inlined function instead of ERR_PTR(PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3642882b-edab-1667-f370-47e8358edc82@ti.com>
Date:   Wed, 13 Nov 2019 16:35:34 +0530
From:   Lokesh Vutla <lokeshvutla@...com>
To:     Marc Zyngier <maz@...nel.org>
CC:     Markus Elfring <markus.elfring@....de>,
        <linux-arm-kernel@...ts.infradead.org>,
        Jason Cooper <jason@...edaemon.net>,
        Nishanth Menon <nm@...com>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Tero Kristo <t-kristo@...com>,
        Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] irqchip/ti-sci-inta: Use ERR_CAST inlined function
 instead of ERR_PTR(PTR_ERR(...))



On 11/11/19 3:45 PM, Marc Zyngier wrote:
> On 2019-11-11 04:45, Lokesh Vutla wrote:
>> On 05/11/19 5:00 PM, Markus Elfring wrote:
>>> From: Markus Elfring <elfring@...rs.sourceforge.net>
>>> Date: Tue, 5 Nov 2019 12:19:39 +0100
>>>
>>> A coccicheck run provided information like the following.
>>>
>>> drivers/irqchip/irq-ti-sci-inta.c:250:9-16: WARNING: ERR_CAST can be used
>>> with vint_desc.
>>>
>>> Generated by: scripts/coccinelle/api/err_cast.cocci
>>>
>>> Thus adjust the exception handling in one if branch.
>>>
>>> Fixes: 9f1463b86c13277d0bd88d5ee359577ef40f4da7 ("irqchip/ti-sci-inta: Add
>>> support for Interrupt Aggregator driver")
>>
>> Fixes: 9f1463b86c13 ("irqchip/ti-sci-inta: Add support for Interrupt
>> Aggregator driver")
> 
> I fundamentally disagree with the "Fixes:" tag. This isn't a fix,
> just a minor readability improvement. Flagging things as "Fixes:"
> ends up triggering all kind of unnecessary backports to -stable.
> 
>> With this:

Fine with me. Please drop the fixes tag.

Thanks and regards.
Lokesh

>>
>> Reviewed-by: Lokesh Vutla <lokeshvutla@...com>
> 
> I'll otherwise take this patch in -next.
> 
> Thanks,
> 
>         M.