linux-kernel - Re: [PATCH 3/5] iio: ping: add parallax ping sensors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 13 Nov 2019 12:09:43 +0100
From:   Michal Vokáč <michal.vokac@...ft.com>
To:     Jonathan Cameron <jic23@...nel.org>,
        Andreas Klinger <ak@...klinger.de>
Cc:     robh+dt@...nel.org, mark.rutland@....com, mripard@...nel.org,
        shawnguo@...nel.org, heiko@...ech.de, icenowy@...c.io,
        laurent.pinchart@...asonboard.com, knaack.h@....de,
        lars@...afoo.de, pmeerw@...erw.net, gregkh@...uxfoundation.org,
        christophe.jaillet@...adoo.fr, tglx@...utronix.de,
        mchehab+samsung@...nel.org, davem@...emloft.net,
        paulmck@...ux.ibm.com, devicetree@...r.kernel.org,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] iio: ping: add parallax ping sensors

On 10. 11. 19 18:06, Jonathan Cameron wrote:
> On Thu, 7 Nov 2019 14:00:47 +0100
> Andreas Klinger <ak@...klinger.de> wrote:
  
[snip]

>> + *
>> + *          +---+            +------------------------+
>> + * GPIO     |   |            |                        |
>> + * ping:  --+   +------------+                        +----------------
>> + *          ^   ^            ^                        ^
>> + *          |<->|            interrupt                interrupt
>> + *         udelay(5)         (ts_rising)              (ts_falling)
>> + *                           |<---------------------->|
>> + *                           .  pulse time measured
>> + *                           .  --> one round trip of ultra sonic waves
>> + *                           .                        .
>> + * ultra           +-+ +-+ +-+                        .
>> + * sonic           | | | | | |                        .
>> + * burst: ---------+ +-+ +-+ +-----------------------------------------
>> + *                                                    .
>> + * ultra                                    +-+ +-+ +-+
>> + * sonic                                    | | | | | |
>> + * echo:  ----------------------------------+ +-+ +-+ +----------------
> 
> Nice diagram ;)

Using the '+' characters at the edges and '-' characters for levels makes it
not easily readable in some cases. Especially for the short subsequent bursts.
What about this?

      * GPIO      ___              ________________________
      * ping:  __/   \____________/                        \_________________
      *          ^   ^            ^                        ^
      *          |<->|            interrupt                interrupt
      *         udelay(5)         (ts_rising)              (ts_falling)
      *                           |<---------------------->|
      *                           .  pulse time measured
      *                           .  --> one round trip of ultra sonic waves
      *                           .                        .
      * ultra                     .                        .
      * sonic            _   _   _.                        .
      * burst:  ________/ \_/ \_/ \_________________________________________
      *                                                    .
      * ultra                                              .
      * sonic                                     _   _   _.
      * echo:   _________________________________/ \_/ \_/ \_________________
      */

Michal