linux-kernel - Re: [PATCH v2] firmware_class: make firmware caching configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33f2baa2-944a-2bfc-1c50-0e437bf11959@android.com>
Date:   Wed, 13 Nov 2019 16:16:38 -0800
From:   Mark Salyzyn <salyzyn@...roid.com>
To:     Luis Chamberlain <mcgrof@...nel.org>
Cc:     linux-kernel@...r.kernel.org, kernel-team@...roid.com,
        Tim Murray <timmurray@...gle.com>,
        Venkata Narendra Kumar Gutta <vnkgutta@...eaurora.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J . Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH v2] firmware_class: make firmware caching configurable

On 11/13/19 3:16 PM, Luis Chamberlain wrote:
> On Wed, Nov 13, 2019 at 02:54:26PM -0800, Mark Salyzyn wrote:
>> +config FW_CACHE
>> +	bool "Enable firmware caching during suspend"
>> +	depends on PM_SLEEP
>> +	default y if PM_SLEEP
> I think the default y would suffice given you have depends on PM_SLEEP,
> however this also works. So, again:
>
> Acked-by: Luis Chamberlain <mcgrof@...nel.org>
>
>    Luis

Worried about setting FW_CACHE w/o PM_SLEEP, this enforces it.

--Mark