linux-kernel - Re: [PATCH v6 1/2] loop: Report EOPNOTSUPP properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAE=gft6-dOUztUDHQUKDbw=ghdyXfbVD49nax5PiGJmWpAKhVg@mail.gmail.com>
Date:   Thu, 14 Nov 2019 15:19:02 -0800
From:   Evan Green <evgreen@...omium.org>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Jens Axboe <axboe@...nel.dk>,
        Martin K Petersen <martin.petersen@...cle.com>,
        Gwendal Grignou <gwendal@...omium.org>,
        Ming Lei <ming.lei@...hat.com>,
        "Darrick J . Wong" <darrick.wong@...cle.com>,
        Alexis Savery <asavery@...omium.org>,
        Douglas Anderson <dianders@...omium.org>,
        Bart Van Assche <bvanassche@....org>,
        Chaitanya Kulkarni <chaitanya.kulkarni@....com>,
        linux-block <linux-block@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 1/2] loop: Report EOPNOTSUPP properly

On Tue, Nov 12, 2019 at 11:09 AM Evan Green <evgreen@...omium.org> wrote:
>
> On Tue, Nov 12, 2019 at 12:32 AM Christoph Hellwig <hch@...radead.org> wrote:
> >
> > On Mon, Nov 11, 2019 at 10:50:29AM -0800, Evan Green wrote:
> > > -             if (cmd->ret < 0)
> > > +             if (cmd->ret == -EOPNOTSUPP)
> > > +                     ret = BLK_STS_NOTSUPP;
> > > +             else if (cmd->ret < 0)
> > >                       ret = BLK_STS_IOERR;
> >
> > This really should use errno_to_blk_status.  Same for the other hunk.
>
> Seems reasonable, I can switch to that.

Oh wait, the other hunk doesn't deal with blk_status_t at all. Before,
it just translated any errno into -EIO. Now, it translates almost any
errno to -EIO (the almost being EOPNOTSUPP).

So I'll change just the first hunk you pointed out.
-Evan