linux-kernel - Re: [PATCH] sparc: vdso: fix build error of vdso32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191113.162157.111707512627631395.davem@davemloft.net>
Date:   Wed, 13 Nov 2019 16:21:57 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     keescook@...omium.org
Cc:     yamada.masahiro@...ionext.com, sparclinux@...r.kernel.org,
        matorola@...il.com, gregkh@...uxfoundation.org, tglx@...utronix.de,
        linux-kernel@...r.kernel.org, ndesaulniers@...gle.com
Subject: Re: [PATCH] sparc: vdso: fix build error of vdso32

From: Kees Cook <keescook@...omium.org>
Date: Wed, 13 Nov 2019 15:59:27 -0800

> On Sun, Sep 22, 2019 at 08:34:36PM +0900, Masahiro Yamada wrote:
>> Since commit 54b8ae66ae1a ("kbuild: change *FLAGS_<basetarget>.o to
>> take the path relative to $(obj)"), sparc allmodconfig fails to build
>> as follows:
>> 
>>   CC      arch/sparc/vdso/vdso32/vclock_gettime.o
>> unrecognized e_machine 18 arch/sparc/vdso/vdso32/vclock_gettime.o
>> arch/sparc/vdso/vdso32/vclock_gettime.o: failed
>> 
>> The cause of the breakage is that -pg flag not being dropped.
>> 
>> The vdso32 files are located in the vdso32/ subdirectory, but I missed
>> to update the Makefile.
>> 
>> Fixes: 54b8ae66ae1a ("kbuild: change *FLAGS_<basetarget>.o to take the path relative to $(obj)")
>> Reported-by: Anatoly Pugachev <matorola@...il.com>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> 
> I've tripped over this as well. Since no one has picked this up, can you
> take it via your tree Masahiro?

Yes, please do.  Sorry, I haven't had a lot of time for Sparc work lately.

Acked-by: David S. Miller <davem@...emloft.net>