linux-kernel - Re: [PATCH 3/3] tty: serial: tegra: Use dma_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <17285b24-b94b-7e86-d386-c5cf3c15c259@nvidia.com>
Date:   Thu, 14 Nov 2019 07:05:12 +0000
From:   Jon Hunter <jonathanh@...dia.com>
To:     Peter Ujfalusi <peter.ujfalusi@...com>,
        <gregkh@...uxfoundation.org>, <linux@...linux.org.uk>,
        <agross@...nel.org>, <bjorn.andersson@...aro.org>,
        <ldewangan@...dia.com>, <thierry.reding@...il.com>
CC:     <vkoul@...nel.org>, <jslaby@...e.com>,
        <linux-serial@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH 3/3] tty: serial: tegra: Use dma_request_chan() directly
 for channel request


On 13/11/2019 09:46, Peter Ujfalusi wrote:
> dma_request_slave_channel_reason() is:
> #define dma_request_slave_channel_reason(dev, name) \
> 	dma_request_chan(dev, name)
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>
> ---
>  drivers/tty/serial/serial-tegra.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serial/serial-tegra.c b/drivers/tty/serial/serial-tegra.c
> index 2f599515c133..b6ace6290e23 100644
> --- a/drivers/tty/serial/serial-tegra.c
> +++ b/drivers/tty/serial/serial-tegra.c
> @@ -1122,8 +1122,7 @@ static int tegra_uart_dma_channel_allocate(struct tegra_uart_port *tup,
>  	int ret;
>  	struct dma_slave_config dma_sconfig;
>  
> -	dma_chan = dma_request_slave_channel_reason(tup->uport.dev,
> -						dma_to_memory ? "rx" : "tx");
> +	dma_chan = dma_request_chan(tup->uport.dev, dma_to_memory ? "rx" : "tx");
>  	if (IS_ERR(dma_chan)) {
>  		ret = PTR_ERR(dma_chan);
>  		dev_err(tup->uport.dev,
> 

Acked-by: Jon Hunter <jonathanh@...dia.com>

Cheers!
Jon

-- 
nvpublic