linux-kernel - Re: [PATCH v2 1/2] seq_buf: Add printing formatted hex dumps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d937230-9890-aabc-b268-c3a2e1f799b0@intel.com>
Date:   Thu, 14 Nov 2019 09:00:40 +0100
From:   Cezary Rojewski <cezary.rojewski@...el.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Piotr Maziarz <piotrx.maziarz@...ux.intel.com>,
        linux-kernel@...r.kernel.org, mingo@...hat.com,
        andriy.shevchenko@...el.com, gustaw.lewandowski@...el.com
Subject: Re: [PATCH v2 1/2] seq_buf: Add printing formatted hex dumps

On 2019-11-13 22:02, Steven Rostedt wrote:
> On Thu,  7 Nov 2019 13:45:37 +0100
> Piotr Maziarz <piotrx.maziarz@...ux.intel.com> wrote:
> 
>> Provided function is an analogue of print_hex_dump().
>>
>> Implementing this function in seq_buf allows using for multiple
>> purposes (e.g. for tracing) and therefore prevents from code duplication
>> in every layer that uses seq_buf.
>>
>> print_hex_dump() is an essential part of logging data to dmesg. Adding
>> similar capability for other purposes is beneficial to all users.
>>
>> Example usage:
>> seq_buf_hex_dump(seq, "", DUMP_PREFIX_OFFSET, 16, 4, buf,
>> 		 ARRAY_SIZE(buf), true);
>> Example output:
>> 00000000: 00000000 ffffff10 ffffff32 ffff3210  ........2....2..
>> 00000010: ffff3210 83d00437 c0700000 00000000  .2..7.....p.....
>> 00000020: 02010004 0000000f 0000000f 00004002  .............@..
>> 00000030: 00000fff 00000000                    ........
>>
>> Signed-off-by: Piotr Maziarz <piotrx.maziarz@...ux.intel.com>
>> Signed-off-by: Cezary Rojewski <cezary.rojewski@...el.com>
> 
> I'm curious about the two signed off bys? Was Cezary a co-author?
> 

Hello Steven,

Code is done by Piotr. I merely took part in shaping this idea and doing 
initial reviews. Kudos to Andy for helping us out here.

As a dev lead and maintainer for Intel ASoC team, patches coming from my 
team are also being signed off me so any reviewer has a person to 
complain to in case of any issues for extended period of time.

Czarek