linux-kernel - Re: [PATCH v2 12/13] usb: gadget: udc: gr_udc: create debugfs directory under usb root

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1573719874.7173.11.camel@mhfsdcap03>
Date:   Thu, 14 Nov 2019 16:24:34 +0800
From:   Chunfeng Yun <chunfeng.yun@...iatek.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Felipe Balbi <balbi@...nel.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Peter Chen <Peter.Chen@....com>,
        Minas Harutyunyan <hminas@...opsys.com>,
        Cristian Birsan <cristian.birsan@...rochip.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Kevin Cernekee <cernekee@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        <bcm-kernel-feedback-list@...adcom.com>,
        Daniel Mack <daniel@...que.org>,
        Haojian Zhuang <haojian.zhuang@...il.com>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>, Bin Liu <b-liu@...com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        "Stephen Boyd" <swboyd@...omium.org>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Colin Ian King <colin.king@...onical.com>,
        Biju Das <biju.das@...renesas.com>,
        "Fabrizio Castro" <fabrizio.castro@...renesas.com>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Yangtao Li <tiny.windzz@...il.com>,
        <linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-usb@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH v2 12/13] usb: gadget: udc: gr_udc: create debugfs
 directory under usb root

On Thu, 2019-11-14 at 11:21 +0800, Greg Kroah-Hartman wrote:
> On Tue, Nov 12, 2019 at 02:51:58PM +0800, Chunfeng Yun wrote:
> > Now the USB gadget subsystem can use the USB debugfs root directory,
> > so move it's directory from the root of the debugfs filesystem into
> > the root of usb
> > 
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@...iatek.com>
> > ---
> > v2:
> >   1. abandon new API usb_debugfs_create_dir(), and use usb_debug_root
> > ---
> >  drivers/usb/gadget/udc/gr_udc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/usb/gadget/udc/gr_udc.c b/drivers/usb/gadget/udc/gr_udc.c
> > index 7a0e9a58c2d8..5faa09a6c770 100644
> > --- a/drivers/usb/gadget/udc/gr_udc.c
> > +++ b/drivers/usb/gadget/udc/gr_udc.c
> > @@ -208,7 +208,7 @@ static void gr_dfs_create(struct gr_udc *dev)
> >  {
> >  	const char *name = "gr_udc_state";
> >  
> > -	dev->dfs_root = debugfs_create_dir(dev_name(dev->dev), NULL);
> > +	dev->dfs_root = debugfs_create_dir(dev_name(dev->dev), usb_debug_root);
> >  	debugfs_create_file(name, 0444, dev->dfs_root, dev, &gr_dfs_fops);
> >  }
> >  
> 
> This breaks the build:
> drivers/usb/gadget/udc/gr_udc.c: In function ‘gr_dfs_create’:
> drivers/usb/gadget/udc/gr_udc.c:211:57: error: ‘usb_debug_root’ undeclared (first use in this function)
>   211 |  dev->dfs_root = debugfs_create_dir(dev_name(dev->dev), usb_debug_root);
>       |                                                         ^~~~~~~~~~~~~~
> drivers/usb/gadget/udc/gr_udc.c:211:57: note: each undeclared identifier is reported only once for each function it appears in
> make[4]: *** [scripts/Makefile.build:265: drivers/usb/gadget/udc/gr_udc.o] Error 1
> 
> so I've dropped it from the patch series.
> 
> Please fix up and resend.
Ok
> 
> And of course, always test-build your patches before you send them
> out...
Sorry, will do it
> 
> greg k-h