linux-kernel - Re: [PATCH v9 1/2] fork: extend clone3() to support setting a PID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191114083224.hiphdnb2fy4ezia2@wittgenstein>
Date:   Thu, 14 Nov 2019 09:32:25 +0100
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Adrian Reber <areber@...hat.com>
Cc:     Eric Biederman <ebiederm@...ssion.com>,
        Pavel Emelyanov <ovzxemul@...il.com>,
        Jann Horn <jannh@...gle.com>, Oleg Nesterov <oleg@...hat.com>,
        Dmitry Safonov <0x7f454c46@...il.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        linux-kernel@...r.kernel.org, Andrei Vagin <avagin@...il.com>,
        Mike Rapoport <rppt@...ux.ibm.com>,
        Radostin Stoyanov <rstoyanov1@...il.com>
Subject: Re: [PATCH v9 1/2] fork: extend clone3() to support setting a PID

On Thu, Nov 14, 2019 at 09:22:09AM +0100, Adrian Reber wrote:
> On Thu, Nov 14, 2019 at 09:14:00AM +0100, Christian Brauner wrote:
> > On Thu, Nov 14, 2019 at 08:07:08AM +0100, Adrian Reber wrote:
> > >   * The structure is versioned by size and thus extensible.
> > >   * New struct members must go at the end of the struct and
> > > @@ -71,6 +85,8 @@ struct clone_args {
> > >  	__aligned_u64 stack;
> > >  	__aligned_u64 stack_size;
> > >  	__aligned_u64 tls;
> > > +	__aligned_u64 set_tid;
> > > +	__aligned_u64 set_tid_size;
> > 
> > Oh, one thing that is missing is the addition of
> > 
> > +#define CLONE_ARGS_SIZE_VER1 80 /* sizeof second published struct */
> > 
> > in sched.h. Please add that, when you resend.
> 
> Even if it is unused?

Yes, I think so. It's nice for userspace to have these macros for
versioning purposes. We already started exposing this versioning with
_VER0 to userspace.

	Christian