linux-kernel - Re: [PATCH] drm/komeda: Clean warnings: candidate for 'gnu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191114085805.GA29015@jamwan02-TSP300>
Date:   Thu, 14 Nov 2019 08:58:13 +0000
From:   "james qian wang (Arm Technology China)" <james.qian.wang@....com>
To:     Mihail Atanassov <Mihail.Atanassov@....com>
CC:     nd <nd@....com>, Liviu Dudau <Liviu.Dudau@....com>,
        "lowryli@....com" <lowryli@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH] drm/komeda: Clean warnings: candidate for 'gnu_printf’ format attribute

On Thu, Nov 14, 2019 at 08:47:58AM +0000, Mihail Atanassov wrote:
> Hi James,
> 
> On Thursday, 14 November 2019 07:18:56 GMT james qian wang (Arm Technology China) wrote:
> > komeda/komeda_pipeline.c: In function ‘komeda_component_add’:
> > komeda/komeda_pipeline.c:213:3: warning: function ‘komeda_component_add’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
> >    vsnprintf(c->name, sizeof(c->name), name_fmt, args);
> >    ^~~~~~~~~
> 
> The fix for this one isn't in the patch below.

Because the upstream code already have it, But I forgot to update the
comment msg, will send v2 to fix it.

Thanks
James

> > 
> > komeda/komeda_event.c: In function ‘komeda_sprintf’:
> > komeda/komeda_event.c:31:2: warning: function ‘komeda_sprintf’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
> >   num = vsnprintf(str->str + str->len, free_sz, fmt, args);
> > 
> > Signed-off-by: james qian wang (Arm Technology China) <james.qian.wang@....com>
> > ---
> >  drivers/gpu/drm/arm/display/komeda/komeda_event.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> > index bf269683f811..977c38d516da 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> > @@ -17,6 +17,7 @@ struct komeda_str {
> >  
> >  /* return 0 on success,  < 0 on no space.
> >   */
> > +__printf(2, 3)
> >  static int komeda_sprintf(struct komeda_str *str, const char *fmt, ...)
> >  {
> >  	va_list args;
> > -- 
> > 2.20.1
> > 
> > 
> 
> 
> -- 
> Mihail
> 
> 
>