linux-kernel - Re: [PATCH v3 04/10] perf: Add per perf_cpu_context min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191114095114.GP4131@hirez.programming.kicks-ass.net>
Date:   Thu, 14 Nov 2019 10:51:14 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Ian Rogers <irogers@...gle.com>
Cc:     Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Kees Cook <keescook@...omium.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Petr Mladek <pmladek@...e.com>,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
        Qian Cai <cai@....pw>, Joe Lawrence <joe.lawrence@...hat.com>,
        Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
        Sri Krishna chowdary <schowdary@...dia.com>,
        "Uladzislau Rezki (Sony)" <urezki@...il.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Changbin Du <changbin.du@...el.com>,
        Ard Biesheuvel <ardb@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Kent Overstreet <kent.overstreet@...il.com>,
        Gary Hook <Gary.Hook@....com>, Arnd Bergmann <arnd@...db.de>,
        Kan Liang <kan.liang@...ux.intel.com>,
        linux-kernel@...r.kernel.org,
        Stephane Eranian <eranian@...gle.com>,
        Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH v3 04/10] perf: Add per perf_cpu_context min_heap storage

On Wed, Nov 13, 2019 at 04:30:36PM -0800, Ian Rogers wrote:
> +	if (cpuctx) {
> +		event_heap = (struct min_max_heap){
> +			.data = cpuctx->itr_storage,
> +			.size = 0,

C guarantees that unnamed fields get to be 0

> +			.cap = cpuctx->itr_storage_cap,
> +		};
> +	} else {
> +		event_heap = (struct min_max_heap){
> +			.data = itrs,
> +			.size = 0,

idem.

> +			.cap = ARRAY_SIZE(itrs),
> +		};
> +		/* Events not within a CPU context may be on any CPU. */
> +		__heap_add(&event_heap, perf_event_groups_first(groups, -1));
> +

suprious whitespace

> +	}
> +	evt = event_heap.data;
> +
>  	__heap_add(&event_heap, perf_event_groups_first(groups, cpu));