linux-kernel - Re: [PATCH 21/23] y2038: itimer: change implementation to timespec64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Nov 2019 11:52:38 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        y2038 Mailman List <y2038@...ts.linaro.org>,
        Ingo Molnar <mingo@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Anna-Maria Gleixner <anna-maria@...utronix.de>,
        Frederic Weisbecker <frederic@...nel.org>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH 21/23] y2038: itimer: change implementation to timespec64

On Thu, Nov 14, 2019 at 3:06 AM Steven Rostedt <rostedt@...dmis.org> wrote:
> On Wed, 13 Nov 2019 23:28:47 +0100 (CET) Thomas Gleixner <tglx@...utronix.de> wrote:
> > > -           __entry->value_usec     = value->it_value.tv_usec;
> > > +           __entry->value_usec     = value->it_value.tv_nsec / NSEC_PER_USEC;
> > >             __entry->interval_sec   = value->it_interval.tv_sec;
> > > -           __entry->interval_usec  = value->it_interval.tv_usec;
> > > +           __entry->interval_usec  = value->it_interval.tv_nsec / NSEC_PER_USEC;
> >
> > Hmm, having a division in a tracepoint is clearly suboptimal.
>
> Right, we should move the division into the TP_printk()
>
>                 __entry->interval_nsec = alue->it_interval.tv_nsec;
>

Ok, fixed now, thanks for the suggestion!

     Arnd