linux-kernel - Re: [PATCH v2] mm: Cleanup __put_devmap_managed_page() vs ->page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 14 Nov 2019 13:32:37 +0100
From:   Christoph Hellwig <hch@....de>
To:     Dan Williams <dan.j.williams@...el.com>
Cc:     jhubbard@...dia.com, Jan Kara <jack@...e.cz>,
        Christoph Hellwig <hch@....de>,
        Ira Weiny <ira.weiny@...el.com>,
        Jérôme Glisse <jglisse@...hat.com>,
        linux-nvdimm@...ts.01.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org
Subject: Re: [PATCH v2] mm: Cleanup __put_devmap_managed_page() vs
 ->page_free()

On Thu, Nov 14, 2019 at 12:20:13AM -0800, Dan Williams wrote:
> +	if (count > 1) {
> +		/* still busy */
> +		return;
> +	} else if (count == 0) {
> +		/* only triggered by the dev_pagemap shutdown path */
> +		__put_page(page);
> +		return;
> +	} else if (!is_device_private_page(page)) {
> +		/* notify page idle for dax */
> +		wake_up_var(&page->_refcount);
> +		return;
> +	}

No need for an else after a return.