linux-kernel - Re: [PATCH v16 04/19] leds: multicolor: Introduce a multicolor class definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f4c891b6-3ce7-c3d7-447a-7633b96face1@ti.com>
Date:   Thu, 14 Nov 2019 06:56:23 -0600
From:   Dan Murphy <dmurphy@...com>
To:     Martin Fuzzey <martin.fuzzey@...wbird.group>,
        <jacek.anaszewski@...il.com>, <pavel@....cz>
CC:     <linux-leds@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v16 04/19] leds: multicolor: Introduce a multicolor class
 definition

Martin

On 11/14/19 5:24 AM, Martin Fuzzey wrote:
> Hi Dan,
>
> On 04/11/2019 13:36, Dan Murphy wrote:
>> +int devm_led_classdev_multicolor_register_ext(struct device *parent,
>> +                         struct led_classdev_mc *mcled_cdev,
>> +                          struct led_init_data *init_data)
>> +{
>> +    struct led_classdev_mc **dr;
>> +    int ret;
>> +
>> +    dr = devres_alloc(devm_led_classdev_multicolor_release,
>> +              sizeof(*dr), GFP_KERNEL);
>> +    if (!dr)
>> +        return -ENOMEM;
>> +
>> +    ret = led_classdev_multicolor_register(parent, mcled_cdev);
>
>
> This drops init_data, should be led_classdev_multicolor_register_ex
>
Thanks for the issue I will fix and send v17

Dan