linux-kernel - Re: linux-next boot error: general protection fault in __x64_sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a1ybsTEgBd_oOeReTppO=mDBu+6rGufA8Lf+UGK+SgA-A@mail.gmail.com>
Date:   Thu, 14 Nov 2019 14:22:06 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Dmitry Vyukov <dvyukov@...gle.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        syzbot <syzbot+dccce9b26ba09ca49966@...kaller.appspotmail.com>,
        John Stultz <john.stultz@...aro.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Stephen Boyd <sboyd@...nel.org>,
        syzkaller-bugs <syzkaller-bugs@...glegroups.com>,
        "the arch/x86 maintainers" <x86@...nel.org>,
        kasan-dev <kasan-dev@...glegroups.com>,
        Jann Horn <jannh@...gle.com>
Subject: Re: linux-next boot error: general protection fault in __x64_sys_settimeofday

On Thu, Nov 14, 2019 at 1:43 PM Dmitry Vyukov <dvyukov@...gle.com> wrote:
>
> On Thu, Nov 14, 2019 at 1:42 PM Dmitry Vyukov <dvyukov@...gle.com> wrote:
> >
> > On Thu, Nov 14, 2019 at 1:35 PM Thomas Gleixner <tglx@...utronix.de> wrote:
> > >
> > > On Thu, 14 Nov 2019, syzbot wrote:
> > >
> > > From the full console output:

> >
> > Urgently need +Jann's patch to better explain these things!
>
> +Arnd, this does not look right:
>
> commit adde74306a4b05c04dc51f31a08240faf6e97aa9
> Author: Arnd Bergmann <arnd@...db.de>
> Date:   Wed Aug 15 20:04:11 2018 +0200
>
>     y2038: time: avoid timespec usage in settimeofday()
> ...
>
> -               if (!timeval_valid(&user_tv))
> +               if (tv->tv_usec > USEC_PER_SEC)
>                         return -EINVAL;

Thanks for the report!

I was checking the wrong variable, fixed now,
should push it out to my y2038 branch in a bit.

      Arnd