lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 Nov 2019 10:24:09 -0400 From: Jason Gunthorpe <jgg@...pe.ca> To: Ralph Campbell <rcampbell@...dia.com> Cc: Jerome Glisse <jglisse@...hat.com>, John Hubbard <jhubbard@...dia.com>, Christoph Hellwig <hch@....de>, Shuah Khan <shuah@...nel.org>, linux-rdma@...r.kernel.org, linux-mm@...ck.org, linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org Subject: Re: [PATCH v4 1/2] mm/hmm: make full use of walk_page_range() On Mon, Nov 04, 2019 at 02:21:40PM -0800, Ralph Campbell wrote: > hmm_range_fault() calls find_vma() and walk_page_range() in a loop. > This is unnecessary duplication since walk_page_range() calls find_vma() > in a loop already. > Simplify hmm_range_fault() by defining a walk_test() callback function > to filter unhandled vmas. > This also fixes a bug where hmm_range_fault() was not checking > start >= vma->vm_start before checking vma->vm_flags so hmm_range_fault() > could return an error based on the wrong vma for the requested range. > It also fixes a bug when the vma has no read access and the caller did > not request a fault, there shouldn't be any error return code. > > Signed-off-by: Ralph Campbell <rcampbell@...dia.com> > Cc: "Jérôme Glisse" <jglisse@...hat.com> > Cc: Jason Gunthorpe <jgg@...lanox.com> > Cc: Christoph Hellwig <hch@....de> > Reviewed-by: Christoph Hellwig <hch@....de> > --- > mm/hmm.c | 121 ++++++++++++++++++++++++++----------------------------- > 1 file changed, 58 insertions(+), 63 deletions(-) Applied to hmm.git with Christoph's hunk merged in Thanks, Jason
Powered by blists - more mailing lists