linux-kernel - Re: [PATCH] dt-bindings: crypto: Convert stm32 HASH bindings to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191114182733.GA21785@bogus>
Date:   Thu, 14 Nov 2019 12:27:33 -0600
From:   Rob Herring <robh@...nel.org>
To:     Benjamin Gaignard <benjamin.gaignard@...com>
Cc:     herbert@...dor.apana.org.au, davem@...emloft.net,
        mark.rutland@....com, alexandre.torgue@...com,
        lionel.debieve@...com, linux-crypto@...r.kernel.org,
        devicetree@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: crypto: Convert stm32 HASH bindings to
 json-schema

On Fri, Nov 08, 2019 at 01:52:44PM +0100, Benjamin Gaignard wrote:
> Convert the STM32 HASH binding to DT schema format using json-schema
> 
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@...com>
> ---
>  .../devicetree/bindings/crypto/st,stm32-hash.txt   | 30 ----------
>  .../devicetree/bindings/crypto/st,stm32-hash.yaml  | 64 ++++++++++++++++++++++
>  2 files changed, 64 insertions(+), 30 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/crypto/st,stm32-hash.txt
>  create mode 100644 Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml
> 
> diff --git a/Documentation/devicetree/bindings/crypto/st,stm32-hash.txt b/Documentation/devicetree/bindings/crypto/st,stm32-hash.txt
> deleted file mode 100644
> index 04fc246f02f7..000000000000
> --- a/Documentation/devicetree/bindings/crypto/st,stm32-hash.txt
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -* STMicroelectronics STM32 HASH
> -
> -Required properties:
> -- compatible: Should contain entries for this and backward compatible
> -  HASH versions:
> -  - "st,stm32f456-hash" for stm32 F456.
> -  - "st,stm32f756-hash" for stm32 F756.
> -- reg: The address and length of the peripheral registers space
> -- interrupts: the interrupt specifier for the HASH
> -- clocks: The input clock of the HASH instance
> -
> -Optional properties:
> -- resets: The input reset of the HASH instance
> -- dmas: DMA specifiers for the HASH. See the DMA client binding,
> -	 Documentation/devicetree/bindings/dma/dma.txt
> -- dma-names: DMA request name. Should be "in" if a dma is present.
> -- dma-maxburst: Set number of maximum dma burst supported
> -
> -Example:
> -
> -hash1: hash@...60400 {
> -	compatible = "st,stm32f756-hash";
> -	reg = <0x50060400 0x400>;
> -	interrupts = <80>;
> -	clocks = <&rcc 0 STM32F7_AHB2_CLOCK(HASH)>;
> -	resets = <&rcc STM32F7_AHB2_RESET(HASH)>;
> -	dmas = <&dma2 7 2 0x400 0x0>;
> -	dma-names = "in";
> -	dma-maxburst = <0>;
> -};
> diff --git a/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml b/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml
> new file mode 100644
> index 000000000000..3c09c9899021
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/crypto/st,stm32-hash.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: STMicroelectronics STM32 HASH bindings
> +
> +maintainers:
> +  - Lionel Debieve <lionel.debieve@...com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - st,stm32f456-hash
> +      - st,stm32f756-hash
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  resets:
> +    maxItems: 1
> +
> +  dmas:
> +    maxItems: 1
> +
> +  dma-names:
> +    items:
> +      - const: in
> +
> +  dma-maxburst:
> +    description: Set number of maximum dma burst supported

Needs a type ref and some constraints. What's the default?

> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/clock/stm32mp1-clks.h>
> +    #include <dt-bindings/reset/stm32mp1-resets.h>
> +    hash@...02000 {
> +      compatible = "st,stm32f756-hash";
> +      reg = <0x54002000 0x400>;
> +      interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
> +      clocks = <&rcc HASH1>;
> +      resets = <&rcc HASH1_R>;
> +      dmas = <&mdma1 31 0x10 0x1000A02 0x0 0x0>;
> +      dma-names = "in";
> +      dma-maxburst = <2>;
> +    };
> +
> +...
> -- 
> 2.15.0
>