linux-kernel - Re: [PATCH v7 2/5] IMA: Define an IMA hook to measure keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56718c81-86db-c72b-19b7-c563838838d6@linux.microsoft.com>
Date:   Thu, 14 Nov 2019 10:30:37 -0800
From:   Lakshmi Ramasubramanian <nramas@...ux.microsoft.com>
To:     zohar@...ux.ibm.com, dhowells@...hat.com,
        matthewgarrett@...gle.com, sashal@...nel.org,
        jamorris@...ux.microsoft.com, linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org, keyrings@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 2/5] IMA: Define an IMA hook to measure keys

On 11/13/19 7:11 PM, Lakshmi Ramasubramanian wrote:

> The IMA hook is defined in a new file namely ima_asymmetric_keys.c
> which is built only if CONFIG_KEYS is enabled.

I think instead of CONFIG_KEYS I should use 
CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE for ima_asymmetric_keys.c since 
this config is enabled only when both CONFIG_ASYMMETRIC_KEY_TYPE and 
CONFIG_KEYS are enabled.

Please see below taken from "crypto/asymmetric_keys/Kconfig"

# SPDX-License-Identifier: GPL-2.0
menuconfig ASYMMETRIC_KEY_TYPE
         bool "Asymmetric (public-key cryptographic) key type"
         depends on KEYS
         help
           This option provides support for a key type that holds the 
data for
           the asymmetric keys used for public key cryptographic 
operations such
           as encryption, decryption, signature generation and signature
           verification.

if ASYMMETRIC_KEY_TYPE

config ASYMMETRIC_PUBLIC_KEY_SUBTYPE
         tristate "Asymmetric public-key crypto algorithm subtype"

endif # ASYMMETRIC_KEY_TYPE

thanks,
  -lakshmi