linux-kernel - Re: [PATCH v2 1/5] dt-bindings: arm: Convert sprd board/soc bindings to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Nov 2019 13:19:27 -0600
From:   Rob Herring <robh@...nel.org>
To:     Chunyan Zhang <chunyan.zhang@...soc.com>
Cc:     Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Orson Zhai <orsonzhai@...il.com>,
        Baolin Wang <baolin.wang7@...il.com>,
        Chunyan Zhang <zhang.lyra@...il.com>
Subject: Re: [PATCH v2 1/5] dt-bindings: arm: Convert sprd board/soc bindings
 to json-schema

On Mon, Nov 11, 2019 at 05:02:26PM +0800, Chunyan Zhang wrote:
> 
> Convert Unisoc (formerly Spreadtrum) SoC bindings to DT schema format
> using json-schema.
> 
> Signed-off-by: Chunyan Zhang <chunyan.zhang@...soc.com>
> ---
>  .../devicetree/bindings/arm/sprd.txt          | 14 ---------
>  .../devicetree/bindings/arm/sprd.yaml         | 29 +++++++++++++++++++
>  2 files changed, 29 insertions(+), 14 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/arm/sprd.txt
>  create mode 100644 Documentation/devicetree/bindings/arm/sprd.yaml
> 
> diff --git a/Documentation/devicetree/bindings/arm/sprd.txt b/Documentation/devicetree/bindings/arm/sprd.txt
> deleted file mode 100644
> index 3df034b13e28..000000000000
> --- a/Documentation/devicetree/bindings/arm/sprd.txt
> +++ /dev/null
> @@ -1,14 +0,0 @@
> -Spreadtrum SoC Platforms Device Tree Bindings
> -----------------------------------------------------
> -
> -SC9836 openphone Board
> -Required root node properties:
> -	- compatible = "sprd,sc9836-openphone", "sprd,sc9836";
> -
> -SC9860 SoC
> -Required root node properties:
> -	- compatible = "sprd,sc9860"
> -
> -SP9860G 3GFHD Board
> -Required root node properties:
> -	- compatible = "sprd,sp9860g-1h10", "sprd,sc9860";
> diff --git a/Documentation/devicetree/bindings/arm/sprd.yaml b/Documentation/devicetree/bindings/arm/sprd.yaml
> new file mode 100644
> index 000000000000..8540758188d8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/sprd.yaml
> @@ -0,0 +1,29 @@
> +# SPDX-License-Identifier: GPL-2.0

You made all the commits to the old file, so can you dual license:

# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)

With that:

Reviewed-by: Rob Herring <robh@...nel.org>

> +# Copyright 2019 Unisoc Inc.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/sprd.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Unisoc platforms device tree bindings
> +
> +maintainers:
> +  - Orson Zhai <orsonzhai@...il.com>
> +  - Baolin Wang <baolin.wang7@...il.com>
> +  - Chunyan Zhang <zhang.lyra@...il.com>
> +
> +properties:
> +  $nodename:
> +    const: '/'
> +  compatible:
> +    oneOf:
> +      - items:
> +          - enum:
> +              - sprd,sc9836-openphone
> +          - const: sprd,sc9836
> +      - items:
> +          - enum:
> +              - sprd,sp9860g-1h10
> +          - const: sprd,sc9860
> +
> +...
> -- 
> 2.20.1
> 
>